Closed Bug 1663283 Opened 4 years ago Closed 4 years ago

Bug 1636728 broke printing nested iframes.

Categories

(Core :: Printing: Setup, defect, P1)

defect

Tracking

()

VERIFIED FIXED
82 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 + verified
firefox82 + verified

People

(Reporter: emilio, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached file t.html (deleted) —
No description provided.

[Tracking Requested - why for this release]: Important printing regression.

Severity: -- → S1
Priority: -- → P1

Cloning of the nested documents should be recursive, I am dum dum.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25414 for changes under testing/web-platform/tests

This was because bug 1662259 landed right before this, and broke printing nested iframes in a different way, sigh.

Yay tests, though.

Flags: needinfo?(emilio)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Upstream PR merged by moz-wptsync-bot

Comment on attachment 9174072 [details]
Bug 1663283 - Fix printing of nested iframes. r=smaug,jwatt

Beta/Release Uplift Approval Request

  • User impact if declined: nested iframes don't print
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: open attachment in the bug, ctrl + P
  • List of other uplifts needed: Bug 1663140
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): simple change to make a chunk of code recursive.
  • String changes made/needed: none
Attachment #9174072 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9174072 [details]
Bug 1663283 - Fix printing of nested iframes. r=smaug,jwatt

Approved for 81.0b8.

Attachment #9174072 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello,

Confirming this as verified fixed on 82.0a1 (2020-09-20) and 81.0 - pref'd on. Confirmed using Windows 10x64, macOS 10.15 and Ubuntu 20.

Status: RESOLVED → VERIFIED
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: