Bug 1636728 broke printing nested iframes.
Categories
(Core :: Printing: Setup, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox80 | --- | unaffected |
firefox81 | + | verified |
firefox82 | + | verified |
People
(Reporter: emilio, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
Assignee | ||
Comment 1•4 years ago
|
||
[Tracking Requested - why for this release]: Important printing regression.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Cloning of the nested documents should be recursive, I am dum dum.
Updated•4 years ago
|
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Backed out changeset 6645926d8c62 (bug 1663283) for web platform test failures in /html/browsers/windows/iframe-nested-print.html. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314955351&repo=autoland&lineNumber=1534
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=6645926d8c62be62871dcda272858df545cbd941
Backout:
https://hg.mozilla.org/integration/autoland/rev/5a77c0b857048d46fe4bced46b2234b49dcc84a2
Assignee | ||
Comment 6•4 years ago
|
||
This was because bug 1662259 landed right before this, and broke printing nested iframes in a different way, sigh.
Yay tests, though.
Comment 8•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Assignee | ||
Comment 10•4 years ago
|
||
Comment on attachment 9174072 [details]
Bug 1663283 - Fix printing of nested iframes. r=smaug,jwatt
Beta/Release Uplift Approval Request
- User impact if declined: nested iframes don't print
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: open attachment in the bug, ctrl + P
- List of other uplifts needed: Bug 1663140
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): simple change to make a chunk of code recursive.
- String changes made/needed: none
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Comment on attachment 9174072 [details]
Bug 1663283 - Fix printing of nested iframes. r=smaug,jwatt
Approved for 81.0b8.
Comment 12•4 years ago
|
||
bugherder uplift |
Comment 13•4 years ago
|
||
Hello,
Confirming this as verified fixed on 82.0a1 (2020-09-20) and 81.0 - pref'd on. Confirmed using Windows 10x64, macOS 10.15 and Ubuntu 20.
Updated•4 years ago
|
Description
•