Closed Bug 1663562 Opened 4 years ago Closed 4 years ago

need to call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats
(deleted), text/x-phabricator-request
Details

When I start setting the pref ui.useOverlayScrollbars in bug 1663537 we trigger this assert

###!!! ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing', file /builds/worker/checkouts/gecko/layout/base/PresShell.cpp, line 2677
#01: mozilla::PresShell::MaybeReflowForInflationScreenSizeChange() [layout/base/PresShell.cpp:11148]
#02: mozilla::PresShell::CompleteChangeToVisualViewportSize() [layout/base/PresShell.cpp:11177]
#03: MobileViewportManager::UpdateVisualViewportSize(mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ScreenPixel> const&) [layout/base/MobileViewportManager.cpp:504]
#04: MobileViewportManager::RefreshVisualViewportSize() [layout/base/MobileViewportManager.cpp:557]
#05: nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/nsGfxScrollFrame.cpp:1340]
#06: nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:1115]
#07: mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/ViewportFrame.cpp:297]
#08: mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) [layout/base/PresShell.cpp:9650]
#09: mozilla::PresShell::ProcessReflowCommands(bool) [layout/base/PresShell.cpp:9816]
#10: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4239]
#11: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:2139]
#12: mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) [layout/base/nsRefreshDriver.cpp:345]
#13: mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:368]
#14: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:738]
#15: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyParentProcessVsync() [layout/base/nsRefreshDriver.cpp:639]
#16: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::ParentProcessVsyncNotifier::Run() [layout/base/nsRefreshDriver.cpp:538]
#17: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:243]

This happens after the test is finish when we unset the ui.useOverlayScrollbars pref which (I'm assuming because it must) causes reflow. When running a font-inflation related reftest we also unset the font inflation related prefs that were specified in the reftest.list file. This causes font-inflation to go from enabled to disabled and we detect that for the first time while reflowing the scroll frame.

Instead we should reflow when any pref that could affect font inflation is changed. I scanned the font-inflation code in PresShell and Document::GetViewportInfo for prefs are consulted, but I didn't go a super exhaustive search.

When I start setting the pref ui.useOverlayScrollbars in bug 1663537 we trigger this assert

###!!! ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing', file /builds/worker/checkouts/gecko/layout/base/PresShell.cpp, line 2677
#01: mozilla::PresShell::MaybeReflowForInflationScreenSizeChange() [layout/base/PresShell.cpp:11148]
#02: mozilla::PresShell::CompleteChangeToVisualViewportSize() [layout/base/PresShell.cpp:11177]
#03: MobileViewportManager::UpdateVisualViewportSize(mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ScreenPixel> const&) [layout/base/MobileViewportManager.cpp:504]
#04: MobileViewportManager::RefreshVisualViewportSize() [layout/base/MobileViewportManager.cpp:557]
#05: nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/nsGfxScrollFrame.cpp:1340]
#06: nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:1115]
#07: mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/ViewportFrame.cpp:297]
#08: mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) [layout/base/PresShell.cpp:9650]
#09: mozilla::PresShell::ProcessReflowCommands(bool) [layout/base/PresShell.cpp:9816]
#10: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4239]
#11: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:2139]
#12: mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) [layout/base/nsRefreshDriver.cpp:345]
#13: mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:368]
#14: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:738]
#15: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyParentProcessVsync() [layout/base/nsRefreshDriver.cpp:639]
#16: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::ParentProcessVsyncNotifier::Run() [layout/base/nsRefreshDriver.cpp:538]
#17: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:243]

This happens after the test is finish when we unset the ui.useOverlayScrollbars pref which (I'm assuming because it must) causes reflow. When running a font-inflation related reftest we also unset the font inflation related prefs that were specified in the reftest.list file. This causes font-inflation to go from enabled to disabled and we detect that for the first time while reflowing the scroll frame.

Instead we should reflow when any pref that could affect font inflation is changed. I scanned the font-inflation code in PresShell and Document::GetViewportInfo for prefs are consulted, but I didn't go a super exhaustive search.

Blocks: 1663537
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6698b842822e
Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats

Backed out changeset 6698b842822e (bug 1663562) for mozglue_static::panic_hook crashes.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-linux1804-64-qr%2Fdebug-mochitest-plain-e10s%2C16&fromchange=a23e9879c8485e6717c9f2519cc5a40031a8b3ec&tochange=190ed8e734b291a1c4932fe2c99514b4b3f8dacf&selectedTaskRun=CrpEoBR1TXa-064eScwHGg.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/190ed8e734b291a1c4932fe2c99514b4b3f8dacf

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315169647&repo=autoland&lineNumber=5609

[task 2020-09-09T01:36:49.894Z] 01:36:49     INFO - TEST-START | dom/base/test/test_meta_viewport_initial_scale_with_trailing_characters.html
[task 2020-09-09T01:36:49.917Z] 01:36:49     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:49.919Z] 01:36:49     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:49.955Z] 01:36:49     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:50.417Z] 01:36:50     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:50.418Z] 01:36:50     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:50.433Z] 01:36:50     INFO - GECKO(1475) | MEMORY STAT | vsize 3025MB | residentFast 276MB | heapAllocated 22MB
[task 2020-09-09T01:36:50.454Z] 01:36:50     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:50.477Z] 01:36:50     INFO - GECKO(1475) | [GFX1-]: DataSourceSurface of SharedSurfaces does not exist for extId:8589936837
[task 2020-09-09T01:36:50.479Z] 01:36:50     INFO - GECKO(1475) | IPDL protocol error: Handler returned error code!
[task 2020-09-09T01:36:50.481Z] 01:36:50     INFO - GECKO(1475) | ###!!! [Parent][DispatchAsyncMessage] Error: PWebRenderBridge::Msg_UpdateResources Processing error: message was deserialized, but the handler returned false (indicating failure)
[task 2020-09-09T01:36:50.602Z] 01:36:50     INFO - TEST-OK | dom/base/test/test_meta_viewport_initial_scale_with_trailing_characters.html | took 696ms
[task 2020-09-09T01:36:50.679Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.681Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.682Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.683Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.684Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.684Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.686Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.686Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.687Z] 01:36:50     INFO - GECKO(1475) | [2020-09-09T01:36:50Z WARN  webrender::resource_cache] Delete the non-exist key
[task 2020-09-09T01:36:50.707Z] 01:36:50     INFO - GECKO(1475) | Hit MOZ_CRASH(Non-tiled image with no visible images detected! Properties None) at gfx/wr/webrender/src/batch.rs:2300
[task 2020-09-09T01:36:50.714Z] 01:36:50     INFO - GECKO(1475) | ExceptionHandler::GenerateDump cloned child 1901
[task 2020-09-09T01:36:50.715Z] 01:36:50     INFO - GECKO(1475) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2020-09-09T01:36:50.716Z] 01:36:50     INFO - GECKO(1475) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2020-09-09T01:36:50.878Z] 01:36:50     INFO - GECKO(1475) | Exiting due to channel error.
[task 2020-09-09T01:36:50.882Z] 01:36:50     INFO - GECKO(1475) | Exiting due to channel error.
[task 2020-09-09T01:36:50.883Z] 01:36:50     INFO - GECKO(1475) | Exiting due to channel error.
[task 2020-09-09T01:36:50.885Z] 01:36:50     INFO - GECKO(1475) | Exiting due to channel error.
[task 2020-09-09T01:36:50.905Z] 01:36:50     INFO - GECKO(1475) | [RDD 1763, Main Thread] WARNING: Shutting down RDD process early due to a crash!: file /builds/worker/checkouts/gecko/dom/media/ipc/RDDParent.cpp, line 203
[task 2020-09-09T01:36:50.921Z] 01:36:50     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:50.921Z] 01:36:50     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:50.938Z] 01:36:50     INFO - TEST-INFO | Main app process: exit 11
[task 2020-09-09T01:36:50.938Z] 01:36:50     INFO - Buffered messages finished
[task 2020-09-09T01:36:50.938Z] 01:36:50    ERROR - TEST-UNEXPECTED-FAIL | dom/base/test/test_meta_viewport_initial_scale_with_trailing_characters.html (finished) | application terminated with exit code 11
[task 2020-09-09T01:36:50.938Z] 01:36:50     INFO - runtests.py | Application ran for: 0:08:50.080829
[task 2020-09-09T01:36:50.938Z] 01:36:50     INFO - zombiecheck | Reading PID log: /tmp/tmp1no7Abpidlog
[task 2020-09-09T01:36:50.939Z] 01:36:50     INFO - ==> process 1475 launched child process 1497
[task 2020-09-09T01:36:50.939Z] 01:36:50     INFO - ==> process 1475 launched child process 1594
[task 2020-09-09T01:36:50.940Z] 01:36:50     INFO - ==> process 1475 launched child process 1618
[task 2020-09-09T01:36:50.940Z] 01:36:50     INFO - ==> process 1475 launched child process 1680
[task 2020-09-09T01:36:50.940Z] 01:36:50     INFO - ==> process 1475 launched child process 1705
[task 2020-09-09T01:36:50.941Z] 01:36:50     INFO - ==> process 1475 launched child process 1763
[task 2020-09-09T01:36:50.941Z] 01:36:50     INFO - zombiecheck | Checking for orphan process with PID: 1763
[task 2020-09-09T01:36:50.943Z] 01:36:50     INFO - zombiecheck | Checking for orphan process with PID: 1705
[task 2020-09-09T01:36:50.943Z] 01:36:50     INFO - zombiecheck | Checking for orphan process with PID: 1680
...
[task 2020-09-09T01:36:56.466Z] 01:36:56     INFO -  JavaScript error: /builds/worker/workspace/build/tests/bin/components/httpd.js, line 3829: NS_ERROR_NOT_AVAILABLE:
[task 2020-09-09T01:36:56.610Z] 01:36:56     INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/27f6057c-3af3-6a13-bdbd-4c356d339632.dmp
[task 2020-09-09T01:36:56.611Z] 01:36:56     INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/27f6057c-3af3-6a13-bdbd-4c356d339632.extra
[task 2020-09-09T01:36:56.776Z] 01:36:56     INFO - PROCESS-CRASH | dom/base/test/test_meta_viewport_initial_scale_with_trailing_characters.html (finished) | application crashed [@ mozglue_static::panic_hook]
[task 2020-09-09T01:36:56.776Z] 01:36:56     INFO - Mozilla crash reason: Non-tiled image with no visible images detected! Properties None
[task 2020-09-09T01:36:56.776Z] 01:36:56     INFO - Crash dump filename: /tmp/tmpzBVnsT.mozrunner/minidumps/27f6057c-3af3-6a13-bdbd-4c356d339632.dmp
[task 2020-09-09T01:36:56.777Z] 01:36:56     INFO - Operating system: Linux
[task 2020-09-09T01:36:56.777Z] 01:36:56     INFO -                   0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO - CPU: amd64
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO -      family 6 model 85 stepping 4
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO -      2 CPUs
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO - 
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO - GPU: UNKNOWN
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO - 
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO - Crash reason:  SIGSEGV /SEGV_MAPERR
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO - Crash address: 0x0
[task 2020-09-09T01:36:56.778Z] 01:36:56     INFO - Process uptime: not available
[task 2020-09-09T01:36:56.779Z] 01:36:56     INFO - 
[task 2020-09-09T01:36:56.779Z] 01:36:56     INFO - Thread 32 (crashed)
[task 2020-09-09T01:36:56.779Z] 01:36:56     INFO -  0  libxul.so!RustMozCrash [wrappers.cpp:6698b842822e238196b46001e4d4770bb8781bec : 17 + 0x15]
[task 2020-09-09T01:36:56.780Z] 01:36:56     INFO -     rax = 0x000055f073454248   rdx = 0x0000000000000000
[task 2020-09-09T01:36:56.780Z] 01:36:56     INFO -     rcx = 0x0000000000000b40   rbx = 0x00007fb49abec1ca
[task 2020-09-09T01:36:56.780Z] 01:36:56     INFO -     rsi = 0x00007fb4ca5148b0   rdi = 0x00007fb4ca513680
[task 2020-09-09T01:36:56.781Z] 01:36:56     INFO -     rbp = 0x00007fb49abebfb0   rsp = 0x00007fb49abebfa0
[task 2020-09-09T01:36:56.781Z] 01:36:56     INFO -      r8 = 0x00007fb4ca5148b0    r9 = 0x00007fb49abfd700
[task 2020-09-09T01:36:56.781Z] 01:36:56     INFO -     r10 = 0x0000000000000000   r11 = 0x0000000000000000
[task 2020-09-09T01:36:56.784Z] 01:36:56     INFO -     r12 = 0x00000000000008fc   r13 = 0x000000000000001d
[task 2020-09-09T01:36:56.784Z] 01:36:56     INFO -     r14 = 0x00000000000008fc   r15 = 0x00007fb48a0c6980
[task 2020-09-09T01:36:56.784Z] 01:36:56     INFO -     rip = 0x00007fb4bf24ad4c
[task 2020-09-09T01:36:56.785Z] 01:36:56     INFO -     Found by: given as instruction pointer in context
[task 2020-09-09T01:36:56.786Z] 01:36:56     INFO -  1  libxul.so!mozglue_static::panic_hook [lib.rs:6698b842822e238196b46001e4d4770bb8781bec : 89 + 0x9]
[task 2020-09-09T01:36:56.786Z] 01:36:56     INFO -     rbx = 0x00007fb4c0401cd8   rbp = 0x00007fb49abec400
[task 2020-09-09T01:36:56.787Z] 01:36:56     INFO -     rsp = 0x00007fb49abebfc0   r12 = 0x00000000000008fc
[task 2020-09-09T01:36:56.787Z] 01:36:56     INFO -     r13 = 0x000000000000001d   r14 = 0x00007fb4b8222540
[task 2020-09-09T01:36:56.787Z] 01:36:56     INFO -     r15 = 0x00007fb48a0c6980   rip = 0x00007fb4bf24ad08
[task 2020-09-09T01:36:56.787Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.788Z] 01:36:56     INFO -  2  libxul.so!core::ops::function::Fn::call [function.rs:4fb7144ed159f94491249e86d5bbd033b5d60550 : 72 + 0xc]
[task 2020-09-09T01:36:56.788Z] 01:36:56     INFO -     rbx = 0x0000000000000001   rbp = 0x00007fb49abec410
[task 2020-09-09T01:36:56.788Z] 01:36:56     INFO -     rsp = 0x00007fb49abec410   r12 = 0x0000000000000001
[task 2020-09-09T01:36:56.789Z] 01:36:56     INFO -     r13 = 0x00007fb4c0424fc0   r14 = 0x00007fb4c04ec218
[task 2020-09-09T01:36:56.789Z] 01:36:56     INFO -     r15 = 0x00007fb49abec4e8   rip = 0x00007fb4bf24a83c
[task 2020-09-09T01:36:56.789Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.790Z] 01:36:56     INFO -  3  libxul.so!std::panicking::rust_panic_with_hook [panicking.rs:4fb7144ed159f94491249e86d5bbd033b5d60550 : 474 + 0x7]
[task 2020-09-09T01:36:56.791Z] 01:36:56     INFO -     rbx = 0x0000000000000001   rbp = 0x00007fb4b84ec648
[task 2020-09-09T01:36:56.791Z] 01:36:56     INFO -     rsp = 0x00007fb49abec420   r12 = 0x0000000000000001
[task 2020-09-09T01:36:56.791Z] 01:36:56     INFO -     r13 = 0x00007fb4c0424fc0   r14 = 0x00007fb4c04ec218
[task 2020-09-09T01:36:56.792Z] 01:36:56     INFO -     r15 = 0x00007fb49abec4e8   rip = 0x00007fb4bff57ed5
[task 2020-09-09T01:36:56.792Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.793Z] 01:36:56     INFO -  4  libxul.so!rust_begin_unwind [panicking.rs:4fb7144ed159f94491249e86d5bbd033b5d60550 : 378 + 0x2f]
[task 2020-09-09T01:36:56.793Z] 01:36:56     INFO -     rbx = 0x00007fb49abec520   rbp = 0x00007fb49abecea0
[task 2020-09-09T01:36:56.793Z] 01:36:56     INFO -     rsp = 0x00007fb49abec4e0   r12 = 0x0000000000000564
[task 2020-09-09T01:36:56.794Z] 01:36:56     INFO -     r13 = 0x00007fb48b2bd000   r14 = 0x00007fb4c0401cd8
[task 2020-09-09T01:36:56.794Z] 01:36:56     INFO -     r15 = 0x0000000000000030   rip = 0x00007fb4bff579eb
[task 2020-09-09T01:36:56.794Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.795Z] 01:36:56     INFO -  5  libxul.so!std::panicking::begin_panic_fmt [panicking.rs:4fb7144ed159f94491249e86d5bbd033b5d60550 : 332 + 0x6]
[task 2020-09-09T01:36:56.795Z] 01:36:56     INFO -     rbx = 0x00007fb49abecdb0   rbp = 0x00007fb49abecea0
[task 2020-09-09T01:36:56.796Z] 01:36:56     INFO -     rsp = 0x00007fb49abec520   r12 = 0x0000000000000564
[task 2020-09-09T01:36:56.796Z] 01:36:56     INFO -     r13 = 0x00007fb48b2bd000   r14 = 0x00007fb49abf9e70
[task 2020-09-09T01:36:56.796Z] 01:36:56     INFO -     r15 = 0x0000000000000030   rip = 0x00007fb4bff5795b
[task 2020-09-09T01:36:56.797Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.797Z] 01:36:56     INFO -  6  libxul.so!webrender::batch::BatchBuilder::add_prim_to_batch [batch.rs:6698b842822e238196b46001e4d4770bb8781bec : 883 + 0x10c]
[task 2020-09-09T01:36:56.798Z] 01:36:56     INFO -     rbx = 0x00007fb48b2bd564   rbp = 0x00007fb49abecea0
[task 2020-09-09T01:36:56.798Z] 01:36:56     INFO -     rsp = 0x00007fb49abec550   r12 = 0x0000000000000564
[task 2020-09-09T01:36:56.798Z] 01:36:56     INFO -     r13 = 0x00007fb48b2bd000   r14 = 0x00007fb49abf9e70
[task 2020-09-09T01:36:56.799Z] 01:36:56     INFO -     r15 = 0x0000000000000030   rip = 0x00007fb4bee097a9
[task 2020-09-09T01:36:56.799Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.800Z] 01:36:56     INFO -  7  libxul.so!webrender::batch::BatchBuilder::add_pic_to_batch [batch.rs:6698b842822e238196b46001e4d4770bb8781bec : 776 + 0x31]
[task 2020-09-09T01:36:56.800Z] 01:36:56     INFO -     rbx = 0x00007fb49abed210   rbp = 0x00007fb49abecf40
[task 2020-09-09T01:36:56.800Z] 01:36:56     INFO -     rsp = 0x00007fb49abeceb0   r12 = 0x00007fb46b1c3c00
[task 2020-09-09T01:36:56.801Z] 01:36:56     INFO -     r13 = 0x00007fb49abed820   r14 = 0x0000000000000240
[task 2020-09-09T01:36:56.801Z] 01:36:56     INFO -     r15 = 0x00007fb48a29a900   rip = 0x00007fb4bee01da7
[task 2020-09-09T01:36:56.802Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.802Z] 01:36:56     INFO -  8  libxul.so!webrender::frame_builder::FrameBuilder::build [frame_builder.rs:6698b842822e238196b46001e4d4770bb8781bec : 604 + 0x198e]
[task 2020-09-09T01:36:56.802Z] 01:36:56     INFO -     rbx = 0x00007fb49abf9e70   rbp = 0x00007fb49abede70
[task 2020-09-09T01:36:56.803Z] 01:36:56     INFO -     rsp = 0x00007fb49abecf50   r12 = 0x0000000000000192
[task 2020-09-09T01:36:56.803Z] 01:36:56     INFO -     r13 = 0x0000000000145000   r14 = 0x00007fb489fb3560
[task 2020-09-09T01:36:56.804Z] 01:36:56     INFO -     r15 = 0x0000000000000002   rip = 0x00007fb4bee4bb89
[task 2020-09-09T01:36:56.804Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.804Z] 01:36:56     INFO -  9  libxul.so!webrender::render_backend::Document::build_frame [render_backend.rs:6698b842822e238196b46001e4d4770bb8781bec : 620 + 0x45]
[task 2020-09-09T01:36:56.805Z] 01:36:56     INFO -     rbx = 0x00007fb49b0be020   rbp = 0x00007fb49abedf70
[task 2020-09-09T01:36:56.805Z] 01:36:56     INFO -     rsp = 0x00007fb49abede80   r12 = 0x0000000000000001
[task 2020-09-09T01:36:56.806Z] 01:36:56     INFO -     r13 = 0x00007fb49b0be5e0   r14 = 0x00007fb49abee400
[task 2020-09-09T01:36:56.806Z] 01:36:56     INFO -     r15 = 0x00007fb49b0be790   rip = 0x00007fb4bee9d174
[task 2020-09-09T01:36:56.806Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.807Z] 01:36:56     INFO - 10  libxul.so!webrender::render_backend::RenderBackend::update_document [render_backend.rs:6698b842822e238196b46001e4d4770bb8781bec : 1571 + 0x10]
[task 2020-09-09T01:36:56.807Z] 01:36:56     INFO -     rbx = 0x00007fb49abfa5b8   rbp = 0x00007fb49abf1400
[task 2020-09-09T01:36:56.808Z] 01:36:56     INFO -     rsp = 0x00007fb49abedf80   r12 = 0x00007fb49abf9e70
[task 2020-09-09T01:36:56.808Z] 01:36:56     INFO -     r13 = 0x00007fb49abf9fc8   r14 = 0x00007fb49abf8228
[task 2020-09-09T01:36:56.808Z] 01:36:56     INFO -     r15 = 0x00000237fd0525bf   rip = 0x00007fb4beeafec3
[task 2020-09-09T01:36:56.809Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.809Z] 01:36:56     INFO - 11  libxul.so!webrender::render_backend::RenderBackend::process_api_msg [render_backend.rs:6698b842822e238196b46001e4d4770bb8781bec : 1351 + 0x210]
[task 2020-09-09T01:36:56.810Z] 01:36:56     INFO -     rbx = 0x00007fb46b13a4e0   rbp = 0x00007fb49abf5810
[task 2020-09-09T01:36:56.810Z] 01:36:56     INFO -     rsp = 0x00007fb49abf1410   r12 = 0x0000000000000000
[task 2020-09-09T01:36:56.810Z] 01:36:56     INFO -     r13 = 0x00007fb49abf32c8   r14 = 0x0000000000000008
[task 2020-09-09T01:36:56.811Z] 01:36:56     INFO -     r15 = 0x00007fb46b13a4d8   rip = 0x00007fb4beeac219
[task 2020-09-09T01:36:56.811Z] 01:36:56     INFO -     Found by: call frame info
[task 2020-09-09T01:36:56.812Z] 01:36:56     INFO - 
...
Flags: needinfo?(tnikkel)
Depends on: 1663865

Seems like a webrender issue that we just happen to be tickling somehow, the patch doesn't seem wrong. I filed bug 1663865.

Flags: needinfo?(tnikkel)
Blocks: 1664064
Severity: -- → S3
Status: NEW → ASSIGNED
Attachment #9174302 - Attachment description: Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r?kats → Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats

This is sad, but seems like the least bad option to enable desktop zooming scrollbars reasonable soon.

Depends on D89409

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/574709176152
Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats
https://hg.mozilla.org/integration/autoland/rev/67cbb5422dbc
Don't call MaybeReflowForInflationScreenSizeChange with webrender when running mochitests in dom/base/test to work around webrender bug for now. r=botond

Looks like unified bustage.

Flags: needinfo?(tnikkel)
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb92660b87e5
Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats
https://hg.mozilla.org/integration/autoland/rev/25760b432ecb
Don't call MaybeReflowForInflationScreenSizeChange with webrender when running mochitests in dom/base/test to work around webrender bug for now. r=botond

https://hg.mozilla.org/mozilla-central/rev/cb92660b87e5
https://hg.mozilla.org/mozilla-central/rev/25760b432ecb

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Depends on: 1665507
Attachment #9175660 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: