Open
Bug 1663719
Opened 4 years ago
Updated 3 years ago
Picture-in-Picture toggle variations sometimes pause the video when clicking on them
Categories
(Toolkit :: Picture-in-Picture, defect, P3)
Toolkit
Picture-in-Picture
Tracking
()
NEW
People
(Reporter: mconley, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
STR:
- Set
media.videocontrols.picture-in-picture.video-toggle.mode
to1
. - Visit https://www.cbc.ca/player/play/1785729091945
- Click on the "Play" button on the video
- Hover the video to reveal the toggle, and then click on it:
ER:
PiP should open and the video should continue playing.
AR:
PiP opens and the video pauses.
I think the code that detects and suppressed the click event isn't working exactly as intended.
Reporter | ||
Comment 1•4 years ago
|
||
This makes it easier to avoid a race where layout of the toggle was sometimes
out of date during the mouseup and click events because the underlying UAWidget
had changed. Instead, we wait until the last event (mouseup in the case that
the mousedown occurred on a different target, click in the case that the
mousedown occurred on the same target), and only then trigger Picture-in-Picture.
Updated•4 years ago
|
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Updated•4 years ago
|
Attachment #9175289 -
Attachment description: Bug 1663719 - Only toggle Picture-in-Picture from the mouseup or click events, rather than pointerdown. r?mstriemer! → Bug 1663719 - Only toggle Picture-in-Picture from the mouseup or click events, rather than pointerdown. r?Gijs!
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P3
Reporter | ||
Updated•4 years ago
|
Assignee: mconley → nobody
Status: ASSIGNED → NEW
Reporter | ||
Updated•3 years ago
|
Component: Video/Audio Controls → Picture-in-Picture
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•