Closed Bug 1663803 Opened 4 years ago Closed 4 years ago

Update pdf.js to version 2.7.26

Categories

(Firefox :: PDF Viewer, task)

task
Not set
normal

Tracking

()

VERIFIED FIXED
82 Branch
Tracking Status
firefox81 --- verified
firefox82 --- verified

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1663343 +++

Changes since last update:
#12343 Remove some code/comments relevant for old (pre-Chromium) versions of Opera
#12344 Save form data in XFA datasets when pdf is a mix of acroforms and xfa
#12345 Don't try to save something for a button which is neither a checkbox nor a radio

Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6cc2266faca2 Update pdf.js to version 2.7.26. r=bdahl
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9174562 [details]
Bug 1663803 - Cherry-pick some upstream forms fixes to Firefox 81. r=bdahl

Beta/Release Uplift Approval Request

  • User impact if declined: Saving specific PDF in Firefox that contains input data will not be displayed in Adobe Reader in other 3rd party apps.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment https://github.com/mozilla/pdf.js/issues/12319#issue-691891731
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): This a bit riskier since it adds a new way to save PDF form data that hasn't been widely tested.
  • String changes made/needed:
Attachment #9174562 - Flags: approval-mozilla-beta?
Attachment #9174546 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Attachment #9174546 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

Verified that https://github.com/mozilla/pdf.js/issues/12319#issue-691891731 is indeed fixed now across platforms (Windows 10 64bit, macOS 10.15 and Ubuntu 18.04). it is not entirely fixed though, see issue https://github.com/mozilla/pdf.js/issues/12355#issue-696921128, that will pe handled separately.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Comment on attachment 9174562 [details]
Bug 1663803 - Cherry-pick some upstream forms fixes to Firefox 81. r=bdahl

Approved for 81.0b9.

Attachment #9174562 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #6)

Verified that https://github.com/mozilla/pdf.js/issues/12319#issue-691891731 is indeed fixed now across platforms (Windows 10 64bit, macOS 10.15 and Ubuntu 18.04). it is not entirely fixed though, see issue https://github.com/mozilla/pdf.js/issues/12355#issue-696921128, that will pe handled separately.

Also verified in Firefox 81.0b9 across platforms.

QA Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: