Closed Bug 1663816 Opened 4 years ago Closed 4 years ago

Intermittent editor/spellchecker/tests/test_bug1205983.html | some misspelled words expected: heute ist ein guter - got "German", expected "heuteisteinguter"

Categories

(Core :: Spelling checker, defect, P5)

Product:
Core
Component:
Spelling checker
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed
firefox87 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: malexandru)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])

Attachments

(2 files)

Bug 1663816 - Disable test_bug1205983.html and test_bug697981.html on windows and linux. r=#intermittent-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1663816 - Disable async font fallback for spell-checker tests. r=#intermittent-reviewers
(deleted), text/x-phabricator-request
Details

Filed by: btara [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=315166072&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Wne_Daj6T_WExRkDqs4nzg/runs/0/artifacts/public/logs/live_backing.log

[task 2020-09-09T01:09:40.750Z] 01:09:40 INFO - TEST-START | editor/spellchecker/tests/test_bug1205983.html
[task 2020-09-09T01:09:42.930Z] 01:09:42 INFO - GECKO(2012) | [Child 5980, Main Thread] WARNING: '!editingHost', file /builds/worker/checkouts/gecko/editor/libeditor/HTMLEditor.cpp, line 546
[task 2020-09-09T01:09:42.930Z] 01:09:42 INFO - GECKO(2012) | [Child 5980, Main Thread] WARNING: mozInlineSpellCHecker::UpdateCurrentDictionary() failed, but ignored: 'NS_SUCCEEDED(rvIgnored)', file /builds/worker/checkouts/gecko/editor/libeditor/EditorBase.cpp, line 4631
[task 2020-09-09T01:09:47.031Z] 01:09:47 INFO - TEST-INFO | started process screenshot
[task 2020-09-09T01:09:47.091Z] 01:09:47 INFO - TEST-INFO | screenshot: exit 0
[task 2020-09-09T01:09:47.092Z] 01:09:47 INFO - Buffered messages logged at 01:09:40
[task 2020-09-09T01:09:47.092Z] 01:09:47 INFO - must wait for load
[task 2020-09-09T01:09:47.092Z] 01:09:47 INFO - TEST-PASS | editor/spellchecker/tests/test_bug1205983.html | true expected (de_DE directory should exist)
[task 2020-09-09T01:09:47.093Z] 01:09:47 INFO - Buffered messages logged at 01:09:42
[task 2020-09-09T01:09:47.093Z] 01:09:47 INFO - TEST-PASS | editor/spellchecker/tests/test_bug1205983.html | one misspelled word expected: German
[task 2020-09-09T01:09:47.093Z] 01:09:47 INFO - Buffered messages logged at 01:09:44
[task 2020-09-09T01:09:47.094Z] 01:09:47 INFO - TEST-PASS | editor/spellchecker/tests/test_bug1205983.html | expected en-US
[task 2020-09-09T01:09:47.094Z] 01:09:47 INFO - TEST-PASS | editor/spellchecker/tests/test_bug1205983.html | one misspelled word expected: Nogoodword
[task 2020-09-09T01:09:47.094Z] 01:09:47 INFO - TEST-PASS | editor/spellchecker/tests/test_bug1205983.html | one misspelled word expected: German
[task 2020-09-09T01:09:47.095Z] 01:09:47 INFO - Buffered messages finished
[task 2020-09-09T01:09:47.095Z] 01:09:47 INFO - TEST-UNEXPECTED-FAIL | editor/spellchecker/tests/test_bug1205983.html | some misspelled words expected: heute ist ein guter - got "German", expected "heuteisteinguter"
[task 2020-09-09T01:09:47.095Z] 01:09:47 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2020-09-09T01:09:47.095Z] 01:09:47 INFO - enFocus/</<@editor/spellchecker/tests/test_bug1205983.html:120:9
[task 2020-09-09T01:09:47.095Z] 01:09:47 INFO - GECKO(2012) | MEMORY STAT | vsize 545MB | vsizeMaxContiguous 629MB | residentFast 89MB | heapAllocated 7MB
[task 2020-09-09T01:09:47.095Z] 01:09:47 INFO - TEST-OK | editor/spellchecker/tests/test_bug1205983.html | took 6316ms

Has Regression Range: --- → yes
Keywords: regression
Whiteboard: [retriggered]
Assignee: nobody → malexandru
Status: NEW → ASSIGNED
Assignee: malexandru → nobody
Status: ASSIGNED → NEW
Assignee: nobody → abutkovits
Status: NEW → ASSIGNED
Assignee: abutkovits → nobody
Status: ASSIGNED → NEW

heads up, we are disabling two additional tests- there has been a needinfo here for a while

Flags: needinfo?(jstutte)
Assignee: nobody → abutkovits
Status: NEW → ASSIGNED
Keywords: leave-open
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae4e77e52a24 Disable test_bug1205983.html and test_bug697981.html on windows and linux. r=intermittent-reviewers,jmaher
Component: DOM: Editor → Spelling checker

@jfkthame: would you mind having a look at this?

Flags: needinfo?(jfkthame)

Since the spelling checker is unowned code, I'm a little concerned about silently disabling tests.

Flags: needinfo?(jfkthame)
Flags: needinfo?(jstutte)

(In reply to Mirko Brodesser (:mbrodesser) from comment #20)

Since the spelling checker is unowned code, I'm a little concerned about silently disabling tests.

Yeah, it's not great. I guess these tests are fragile in the face of unexpected reflow, which resets the spell-checking state of the element or something like that.

Maybe we can try running this directory with gfx.font_rendering.fallback.async set to false, and see if that helps. We already have a couple of custom prefs here to try and avoid the effects of lazy font loading. I'll push a try job with the added pref and see if it looks any better.

Flags: needinfo?(jfkthame)

I retriggered a bunch of test runs and haven't seen this failure happen with the pref set to false: https://treeherder.mozilla.org/jobs?repo=try&revision=fd7c700249d18a91434f12f8f8b92873d838e1aa&duplicate_jobs=visible. So I think that's a better solution here.

Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/295f22bac772 Disable async font fallback for spell-checker tests. r=intermittent-reviewers,jmaher
Keywords: leave-open
Whiteboard: [retriggered][stockwell disable-recommended]
Assignee: abutkovits → nobody
Status: ASSIGNED → NEW
Whiteboard: [retriggered]

https://hg.mozilla.org/mozilla-central/rev/295f22bac772

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Assignee: nobody → malexandru
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: