Closed
Bug 1663875
Opened 4 years ago
Closed 4 years ago
WebSocket tests aren't explicitely waiting for the processing of WS requests by the frontend
Categories
(DevTools :: Netmonitor, defect, P2)
DevTools
Netmonitor
Tracking
(firefox82 fixed)
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
For example, this test:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/browser_net_ws-basic.js#25-28
doesn't wait for the NETWORK_EVENT/NETWORK_EVENT_UPDATE/PAYLOAD_READY or anything alike. Instead it assumes that the request is immediately shown, which is very unlikely, even if we disabled batching. This is quite surprising that the test works today as-is!
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → poirot.alex
Whiteboard: dt-fission-m2-reserve
|
|
Assignee | |
Updated•4 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•4 years ago
|
||
These tests was racy, but I couldn't find any opened intermittent on bugzilla?
|
||
Updated•4 years ago
|
Whiteboard: dt-fission-m2-reserve → dt-fission-m2-mvp
|
||
Updated•4 years ago
|
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fb98769808d
Wait for the request completion in WebSocket test. r=bomsy
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•