Closed Bug 1663877 Opened 4 years ago Closed 4 years ago

Better wait for EVENT_TIMINGS from waitForNetworkEvents test helper

Categories

(DevTools :: Netmonitor, task, P2)

Product:
DevTools
Component:
Netmonitor
Type:
task

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(1 file)

Bug 1663877 - Wait for EVENT_TIMINGS, even when netmonitor is filtering.
(deleted), text/x-phabricator-request
Details

waitForNetworkEvents doesn't always wait correctly for EVENT_TIMINGS, especially when filtering is enabled (which is almost always the case...):
https://searchfox.org/mozilla-central/rev/b2716c233e9b4398fc5923cbe150e7f83c7c6c5b/devtools/client/netmonitor/test/head.js#442

I was the one introducing such condition in bug 1622043 and that was probably a mistake...

Status: NEW → ASSIGNED
Whiteboard: dt-fission-m2-reserve
Whiteboard: dt-fission-m2-reserve → dt-fission-m2-mvp
Blocks: tests-and-infra
Severity: -- → S3
Priority: -- → P2
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0fbe70375c0f Wait for EVENT_TIMINGS, even when netmonitor is filtering. r=bomsy

https://hg.mozilla.org/mozilla-central/rev/0fbe70375c0f

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: