Closed Bug 1664135 Opened 4 years ago Closed 4 years ago

Crash in [@ mozilla::wr::RenderCompositorNative::MaybeGrabScreenshot]

Categories

(Core :: Graphics, defect)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 --- unaffected
firefox82 --- fixed

People

(Reporter: aryx, Assigned: mstange)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

Crash report: https://crash-stats.mozilla.org/report/index/705c8717-23e3-41b2-bb4c-d42d50200831

Top 10 frames of crashing thread:

0 XUL mozilla::wr::RenderCompositorNative::MaybeGrabScreenshot gfx/webrender_bindings/RenderCompositorNative.cpp:134
1 XUL mozilla::wr::RendererOGL::UpdateAndRender gfx/webrender_bindings/RendererOGL.cpp:183
2 XUL mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:482
3 XUL mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:360
4 XUL mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void  xpcom/threads/nsThreadUtils.h:1240
5 XUL MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:548
6 XUL base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:35
7 XUL MessageLoop::Run ipc/chromium/src/base/message_loop.cc:309
8 XUL base::Thread::ThreadMain ipc/chromium/src/base/thread.cc:192
9 XUL ThreadFunc ipc/chromium/src/base/platform_thread_posix.cc:40
Flags: needinfo?(mstange.moz)
Severity: -- → S3
Assignee: nobody → mstange.moz
Status: NEW → ASSIGNED
Flags: needinfo?(mstange.moz)

This can return null when the creation of the GL context for the snapshotter fails, for example.

Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/070815d3ff02 Null-check the return value of CreateSnapshotter(). r=mattwoodrow
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/11ba748e25bf Null-check the return value of CreateSnapshotter(). r=mattwoodrow
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Flags: needinfo?(mstange.moz)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: