Closed Bug 1664446 Opened 4 years ago Closed 4 years ago

Intermittent editor/libeditor/tests/test_bug549262.html | check that we didn't get a scroll - got true, expected false | Page is not scrolled down - got +0, expected 29.399999618530273

Categories

(Core :: DOM: Editor, defect, P5)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 --- unaffected
firefox82 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: tnikkel)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(3 files)

Bug 1664446. Disable zoom to focus input for mochitests in editor/libeditor/tests/. r?kats,botond
(deleted), text/x-phabricator-request
Details
Bug 1664446. Increase fuzz in editor/libeditor/tests/test_selection_move_commands.html slightly. r?kats,botond
(deleted), text/x-phabricator-request
Details
Bug 1664446. Properly wait to make sure any potential scroll events get fired in several tests. r?kats,botond
(deleted), text/x-phabricator-request
Details

Filed by: btara [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=315439610&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YU9jsIhZRoWASazzJaERUg/runs/0/artifacts/public/logs/live_backing.log

[task 2020-09-11T11:57:31.281Z] 11:57:31 INFO - 1378 INFO TEST-START | editor/libeditor/tests/test_bug549262.html
[task 2020-09-11T11:57:31.283Z] 11:57:31 INFO - Buffered messages logged at 11:57:27
[task 2020-09-11T11:57:31.283Z] 11:57:31 INFO - 1379 INFO must wait for load
[task 2020-09-11T11:57:31.283Z] 11:57:31 INFO - 1380 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Sanity check
[task 2020-09-11T11:57:31.283Z] 11:57:31 INFO - 1381 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Page is scrolled down
[task 2020-09-11T11:57:31.284Z] 11:57:31 INFO - 1382 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | The content of the editable element has not changed
[task 2020-09-11T11:57:31.284Z] 11:57:31 INFO - 1383 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Page is scrolled up
[task 2020-09-11T11:57:31.284Z] 11:57:31 INFO - 1384 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | The content of the editable element has not changed
[task 2020-09-11T11:57:31.284Z] 11:57:31 INFO - Buffered messages logged at 11:57:28
[task 2020-09-11T11:57:31.284Z] 11:57:31 INFO - 1385 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | check that we didn't get a scroll
[task 2020-09-11T11:57:31.284Z] 11:57:31 INFO - 1386 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Page is not scrolled down
[task 2020-09-11T11:57:31.285Z] 11:57:31 INFO - 1387 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | The content of the editable element has changed
[task 2020-09-11T11:57:31.285Z] 11:57:31 INFO - 1388 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Page is scrolled down
[task 2020-09-11T11:57:31.285Z] 11:57:31 INFO - 1389 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | The content of the editable element has not changed
[task 2020-09-11T11:57:31.285Z] 11:57:31 INFO - 1390 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | check that we didn't get a scroll
[task 2020-09-11T11:57:31.285Z] 11:57:31 INFO - 1391 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Page is not scrolled up
[task 2020-09-11T11:57:31.286Z] 11:57:31 INFO - 1392 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | The content of the editable element has changed
[task 2020-09-11T11:57:31.286Z] 11:57:31 INFO - 1393 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Page is scrolled up
[task 2020-09-11T11:57:31.286Z] 11:57:31 INFO - 1394 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | check that we didn't get a scroll
[task 2020-09-11T11:57:31.286Z] 11:57:31 INFO - 1395 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Page is not scrolled up
[task 2020-09-11T11:57:31.286Z] 11:57:31 INFO - 1396 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Correct element selected
[task 2020-09-11T11:57:31.286Z] 11:57:31 INFO - 1397 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Selection should be moved to the beginning
[task 2020-09-11T11:57:31.287Z] 11:57:31 INFO - 1398 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Page is scrolled down
[task 2020-09-11T11:57:31.287Z] 11:57:31 INFO - Buffered messages finished
[task 2020-09-11T11:57:31.287Z] 11:57:31 WARNING - 1399 INFO TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug549262.html | check that we didn't get a scroll - got true, expected false
[task 2020-09-11T11:57:31.287Z] 11:57:31 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2020-09-11T11:57:31.287Z] 11:57:31 INFO - waitAndCheckNoScrollEvent/</</</<@editor/libeditor/tests/test_bug549262.html:44:11
[task 2020-09-11T11:57:31.287Z] 11:57:31 WARNING - 1400 INFO TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug549262.html | Page is not scrolled down - got +0, expected 29.399999618530273
[task 2020-09-11T11:57:31.288Z] 11:57:31 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2020-09-11T11:57:31.288Z] 11:57:31 INFO - startTest@editor/libeditor/tests/test_bug549262.html:158:5
[task 2020-09-11T11:57:31.288Z] 11:57:31 INFO - 1401 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Correct element selected
[task 2020-09-11T11:57:31.288Z] 11:57:31 INFO - 1402 INFO TEST-PASS | editor/libeditor/tests/test_bug549262.html | Selection should be moved to the end
[task 2020-09-11T11:57:31.288Z] 11:57:31 INFO - 1403 INFO TEST-OK | editor/libeditor/tests/test_bug549262.html | took 1153ms

Has Regression Range: --- → yes

Not sure why esr78 would be affected.

status-firefox-esr78: affected → unaffected

I think the scrolls that zoom to focus input causes are giving us scroll events that we don't expect. I don't think there is a better way around this.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED

Disabling zoom to focused input seems to have slightly changed how much fuzz we get when comparing scroll position.

The two patches here reduce the frequency by a large factor (about 10 times less I think), but there are still some failures that I'm continuing to investigate. I triggered landing of them.

Keywords: leave-open
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfbb0aa09718 Increase fuzz in editor/libeditor/tests/test_selection_move_commands.html slightly. r=botond
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b92fb2d3bc5 Disable zoom to focus input for mochitests in editor/libeditor/tests/. r=botond

Doing rAF rAF flushApzRepaints is not enough to make sure that any potential scroll events are sent to content. The reason is that if the apz repaint request causes us to do scrolling on the main thread then the scrolling will be finished after flushApzRepaints, and the scroll event will be pending, but it's not sent until the next refresh driver tick. So we need to do at least one rAF after flushApzRepaints.

Flags: needinfo?(tnikkel)
Keywords: leave-open
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f51b6c3688a4 Properly wait to make sure any potential scroll events get fired in several tests. r=kats

https://hg.mozilla.org/mozilla-central/rev/f51b6c3688a4

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: