Closed Bug 1664475 Opened 4 years ago Closed 4 years ago

Collect more telemetry for JS execution and compilation

Categories

(Core :: Performance, task, P4)

Product:
Core
Component:
Performance
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: denispal, Assigned: denispal)

References

Details

Attachments

(2 files, 2 obsolete files)

Bug 1664475: Add telemetry probes to collect data for script delazification, xdr encoding time, bytecode caching time, and baseline compilation time. r=nbp!,dexter!,sefeng!,smaug!
(deleted), text/x-phabricator-request
Details
data-review-1664475.md
(deleted), text/plain
chutten
: data-review+
Details

We need some more information on how much time delazification, XDR encoding, etc take during execution to help decide whether speculating these tasks can be beneficial.

Attachment #9175733 - Attachment is obsolete: true
Attached file data-review-1664475.md (obsolete) (deleted) —
Attachment #9176630 - Flags: data-review?(chutten)

Comment on attachment 9176630 [details]
data-review-1664475.md

Cancelling data request review for now, as I am considering removing some of these probes.

Attachment #9176630 - Flags: data-review?(chutten)
Priority: P2 → P4
Attachment #9176630 - Attachment is obsolete: true
Attached file data-review-1664475.md (deleted) —
Attachment #9179477 - Flags: data-review?(chutten)
Attachment #9176779 - Attachment description: Bug 1664475: Add telemetry probes to collect data for script delazification, inline script compile time, xdr encoding time, bytecode caching time, baseline and ion compile time. r=nbp!,dexter!,sefeng!,smaug! → Bug 1664475: Add telemetry probes to collect data for script delazification, xdr encoding time, bytecode caching time, and baseline compilation time. r=nbp!,dexter!,sefeng!,smaug!

Comment on attachment 9179477 [details]
data-review-1664475.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 89.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :denispal is responsible for renewing or removing the collection before it expires in Firefox 89.

Result: datareview+

Attachment #9179477 - Flags: data-review?(chutten) → data-review+
Pushed by dpalmeiro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f175b7cc46a Add telemetry probes to collect data for script delazification, xdr encoding time, bytecode caching time, and baseline compilation time. r=nbp,Dexter,sefeng,smaug

https://hg.mozilla.org/mozilla-central/rev/7f175b7cc46a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Regressions: 1672503
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: