`AutoBlockElementsJoiner::DeleteNodesEntirelyInRangeButKeepTableStructure()` checks whether deleting content is visible or invisible **after** deleting it
Categories
(Core :: DOM: Editor, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
It deletes content in a range, and if it deletes some visible things, stop the caller joining blocks. However, the visibility check is performed after deleting the content from the DOM tree. This is really odd, but the log must be correct (i.e., only when no visible things is deleted, its caller should join adjacent blocks for making users not think nothing happens.
|
Assignee | |
Comment 1•4 years ago
|
||
Oddly, it checks whether it deletes at least one visible thing after deleting
each content from the DOM tree. It should be done before deleting from the
DOM tree because all text nodes become visible if they are not in the DOM tree
anymore.
Unfortunately, this change does not fix any automated test result, but the
base logic --only when it does not delete any visible things, join the adjacent
block elements-- sounds reasonable. Therefore, let's take this change.
Note that without this change, cannot compute "affected ranges" of
getTargetRanges() in the case running this method later.
Depends on D89870
|
||
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•