Open Bug 1665223 Opened 4 years ago Updated 4 years ago

Recently Closed Tabs / Windows menu population should not be implemented on places views, so it can be invoked "manually"

Categories

(Firefox :: Bookmarks & History, task, P3)

task

Tracking

()

Tracking Status
firefox82 --- affected

People

(Reporter: Gijs, Unassigned)

References

Details

To fix bug 492320, I had to jump through some hoops to get things to work. At least part of the issue is that the "popupshowing" event handler for the submenu depends on the places view for the parent menu existing, which means it requires that that submenu has been shown at least once. This is normally OK because you cannot open the submenu without opening its parent - but on macOS, the shortcut can invoke the entry in the submenu directly (in the hidden window), without opening all the menus first.

In any case, also from a separation-of-concerns perspective, the "recently closed" stuff is implemented in session restore, so it shouldn't care about the places view / node / root.

Severity: -- → S4
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.