Closed Bug 1665294 Opened 4 years ago Closed 4 years ago

Using close search-mode will also remove the next alias (if any)

Categories

(Firefox :: Address Bar, defect, P3)

Firefox 82
Desktop
All
defect
Points:
2

Tracking

()

VERIFIED FIXED
83 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 --- disabled
firefox82 --- disabled
firefox83 --- verified
firefox84 --- verified
firefox85 --- verified

People

(Reporter: aflorinescu, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(3 files)

[Sugested Severity:]

S3

[Environment:]

Ubuntu 20.04 / Windows 10 / Mac 10.13.6
82.0a1 2020-09-15

[Steps:]
  1. Open Firefox.
  2. New tab.
  3. type @google @amazon @ddg @google
  4. Click x on google search-mode indicator
[Actual Result:]

[ddg search-mode] @google

[Expected Result:]

[amazon search-mode] @ddg @google

[Note:]

Another way to look at it would be to use "@google @google @google @google @google @google", then close the google search mode, which would remove [google search-mode] + next @google, then will translate the next @google alias into [google search-mode], then close again, repeat.

[Regression-Range:]

This seems to be a recent regression, since in Firefox 81 with the update2.* on, I cannot reproduce.

it sounds like an edge case, should be investigated but it's probably not a show-stopper.

Severity: -- → S3
Priority: -- → P3
QA Whiteboard: [qa-regression-triage]
Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(adw)

Yes, that bug is likely, but I agree with Marco that this isn't urgent, and I'm currently working on higher priority update2 bugs. We'll certainly get to this eventually.

Flags: needinfo?(adw)
Points: --- → 2
Attached video remove-aliases.mp4 (deleted) —

I checked this one, but could not reproduce this on current m-c.
(Please see the attachment)

Could you please check it, Adrian??
Or, If I am misunderstanding, please let me know.

Thanks.

Flags: needinfo?(adrian.florinescu)

Interesting, now mac is behaving properly (10.13.6) but it can still can be reproduced on W10 with latest Nightly 83.0a1 20201012152719.

Flags: needinfo?(adrian.florinescu) → needinfo?(daisuke)

Thank you very much, Adrian!
Yes, and I can reproduce this on ubuntu 18.04 as well.

Flags: needinfo?(daisuke)
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/61dae93abcb1 Avoid capturing click event twice from search mode close button. r=mak
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Hi,

I tested this on W10 on FF 83.0a1 20201012152719, reproduced the issue and then tested it on FF 85.0a1 (2020-12-01) (64-bit) and verified that it's fixed. I also checked it on Beta and release.

Regards, Flor.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: