ScrollFrameHelper::mZoomableByAPZ gets cleared when the scroll frame is reconstructed
Categories
(Core :: Layout: Scrolling and Overflow, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(4 files)
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Otherwise the only time it gets set is when the ZoomConstraintsClient specifically sets it in response to one of the things that can change it. But if the scroll frame gets reconstructed and one of those things don't happen it will be wrong.
This shows up with desktop zooming scrollbars because we check mZoomableByAPZ (or WantAsyncScroll()) before we use the apz scroll path in ScrollFrameHelper::ScrollBy().
Depends on D90383
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
This test covers bug 1665323, bug 1665326, and bug 1665332. (Each bug fixes one problem that comes up with the same STR that this mochitest reproduces.)
I checked that this fails before my patches and passes after them.
|
|
Assignee | |
Updated•4 years ago
|
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03abdf1d3655 Have ZoomConstraintsClient keep it's ZoomConstraints around so it can be queried later. r=kats
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb1437fa93d0 Fetch the value of mZoomableByAPZ in the ScrollFrameHelper constructor so it is always correct. r=kats
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Comment 7•4 years ago
|
||
Backed out for perma failures.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316359686&repo=autoland&lineNumber=2119
Backout: https://hg.mozilla.org/integration/autoland/rev/43a60e424e7ebb2cda9c614d145906206ec90e80
|
|
Assignee | |
Comment 8•4 years ago
|
||
The default constructor initializes the two bools to true.
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/134746c4644d Make sure to initialize all fields of the ZoomConstraints to the correct values on ZoomConstraintsClient in all cases. r=kats
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2b9bbe90d4f Fetch the value of mZoomableByAPZ in the ScrollFrameHelper constructor so it is always correct. r=kats
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/134746c4644d
https://hg.mozilla.org/mozilla-central/rev/a2b9bbe90d4f
|
|
||
Comment 12•4 years ago
|
||
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a6bfdf38fd9 Add test. r=kats
|
|
||
Comment 13•4 years ago
|
||
Backed out for perma failures.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316622092&repo=autoland&lineNumber=4408
Backout: https://hg.mozilla.org/integration/autoland/rev/2a126c0cc022c6a9c6c1c2e1e31d6445dbe3c4d1
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Comment 14•4 years ago
|
||
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3657820482d9 Add test. r=kats
|
||
Comment 15•4 years ago
|
||
| bugherder | ||
Description
•