Open Bug 1666084 Opened 4 years ago Updated 1 year ago

[flatpak] MPRIS Bus Name not unique in flatpak

Categories

(Firefox Build System :: Third Party Packaging, defect, P3)

Desktop
Linux
defect

Tracking

(Not tracked)

People

(Reporter: MeFisto94, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

(Keywords: flatpak)

As outlined here: https://bugzilla.mozilla.org/show_bug.cgi?id=1648024#c1, we follow the MPRIS spec and use the PID, which is namespaced in a flatpak context, so we need a different form of differentiation there.

Could we use profile name for that as we use for the remote?

3 years ago https://bugzilla.mozilla.org/show_bug.cgi?id=1648024#c1 I suggested:

In a Flatpak context a PID is not a suitable key to unique-ify between different instances of Firefox. If you start a second Firefox with a different profile, it will be in a separate PID namespace, so both are likely to believe themselves to be PID 3. A better choice (which is also suitable in the non-Flatpak case) is to use something derived from the D-Bus connection's unique name.

These are defined in https://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol-names-bus. The specification is a little wooly on the details but in practice they have the form ":I.J" for two integers I and J; adjusting for characters which are legal in D-Bus names, perhaps org.mpris.MediaPlayer2.firefox.instance_I_J would be a good option.

Priority: -- → P3
Summary: MPRIS Bus Name not unique in flatpak → [flatpak] MPRIS Bus Name not unique in flatpak
Component: Widget: Gtk → Third Party Packaging
Keywords: flatpak
Product: Core → Firefox Build System

The severity field is not set for this bug.
:gerard-majax, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(lissyx+mozillians)
You need to log in before you can comment on or make changes to this bug.