Closed
Bug 1666230
Opened 4 years ago
Closed 4 years ago
Tidy up CacheIR op metadata
Categories
(Core :: JavaScript Engine: JIT, task, P2)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
83 Branch
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
-
The arg lengths array is used in a few places and can store a byte per op instead of uint32_t for better cache locality.
-
It could also store a transpile flag so we can simplify some code.
Assignee | ||
Comment 1•4 years ago
|
||
Replace argLengths array with a byte-sized struct that stores both the arg length
and transpile flag. Use this flag in WarpOracle instead of the switch-statement.
The flag could also be used by trial inlining to check for un-transpilable ops.
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84818eed989b
Tidy up CacheIR opcode metadata. r=iain
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•