Closed
Bug 1666283
Opened 4 years ago
Closed 4 years ago
Remove extra const qualification on return type of do_GetService
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
const on return types has no effect, and produces clang-tidy warnings wherever these functions are called, so better remove them.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11456e6bf3be
Remove extra const qualification on return type of do_GetService. r=xpcom-reviewers,nika
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
(In reply to Simon Giesecke [:sg] [he/him] from comment #0)
conston return types has no effect
To be pedantic, it can actually have a negative effect, by preventing optimizations like efficient move or RVO! So thank you for removing them. 😀
|
|
Assignee | |
Updated•4 years ago
|
Blocks: clang-based-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•