Closed
Bug 1666485
Opened 4 years ago
Closed 4 years ago
Move nsIDocShell::CreatedDynamically to BrowsingContext
Categories
(Core :: DOM: Navigation, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: u608768, Assigned: u608768)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This was part of the patchset for bug 1572084, but this is needed for bug 1646573.
|
||
Comment 1•4 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #1)
Wasn't this fixed last week
https://searchfox.org/mozilla-central/rev/b58ca45005fe02077c92779483d1b60e9a49687c/docshell/base/nsDocShell.cpp#3126,3128,3135
oh, I was working on a very outdated tree. I don't think it needs to be a synced field though, I'll use this to make it non-synced.
|
|
||
Comment 3•4 years ago
|
||
Well, session history needs it as sync'ed field.
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a81b4130ac14
Make BrowsingContext::CreatedDynamically non-synced, r=nika,kmag
|
||
Comment 6•4 years ago
|
||
Backed out changeset for causing bustages on BrowsingContext.
Backout link: https://hg.mozilla.org/integration/autoland/rev/28a83ee55db400c9a498106d25756822de354427
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316486453&repo=autoland&lineNumber=48347
Flags: needinfo?(kmadan)
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26fd00ccaea4
Make BrowsingContext::CreatedDynamically non-synced, r=nika,kmag
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•