Closed
Bug 1666524
Opened 4 years ago
Closed 4 years ago
Use of unknown property Ci.nsINetworkLinkService.NS_NETWORK_LINK_TYPE_WIFI in browser_platformDetection.js
Categories
(Core :: Networking: DNS, defect, P3)
Core
Networking: DNS
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | unaffected |
| firefox81 | --- | wontfix |
| firefox82 | --- | wontfix |
| firefox83 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1657897 added browser_platformDetection.js, we have a manually (at the moment) run eslint rule that has picked up the following:
browser/components/doh/test/browser/browser_platformDetection.js
23:15 error Use of unknown property Ci.nsINetworkLinkService.NS_NETWORK_LINK_TYPE_WIFI
It looks like the constant should be LINK_TYPE_WIFI. There doesn't seem to be any ill effects of it being wrong.
|
||
Comment 1•4 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #0)
It looks like the constant should be
LINK_TYPE_WIFI. There doesn't seem to be any ill effects of it being wrong.
Nice catch.
Yes, it seems we never actually use the linkType in that test, but it should be fixed.
Severity: -- → S3
Priority: -- → P3
Whiteboard: [necko-triaged]
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
Iteration: --- → 83.1 - Sept 21 - Oct 4
Points: --- → 1
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/779d2d4dac32
Fix used of unknown idl property in browser_platformDetection.js. r=valentin
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
|
||
Updated•3 years ago
|
Keywords: regression
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•