Closed
Bug 1667341
Opened 4 years ago
Closed 4 years ago
Move isDevToolsExtensionContext from the target to the descriptor
Categories
(DevTools :: Framework, task, P3)
DevTools
Framework
Tracking
(firefox83 fixed)
RESOLVED
FIXED
83 Branch
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(2 files)
See comment thread at https://phabricator.services.mozilla.com/D91106#inline-517310
The flag isDevToolsExtensionContext
is currently set on the BrowsingContextTarget. We could set it in the descriptor instead since it's only related to how we handle the TabRemotenessChange event, which is handled by the TabDescriptor now.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•4 years ago
|
||
Comment 3•4 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jdescottes, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(jdescottes)
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87025d0359a6 [devtools] Move isDevToolsExtensionContext from the target to the descriptor r=ochameau,rpl https://hg.mozilla.org/integration/autoland/rev/505cffa82c83 [devtools] Return a descriptor from createTargetForTab r=ochameau
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/87025d0359a6
https://hg.mozilla.org/mozilla-central/rev/505cffa82c83
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•