waitForNavigationCompleted doesn't trigger callback when no load events are expected or page load strategy is None
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(firefox-esr78 unaffected, firefox81 unaffected, firefox82 fixed, firefox83 fixed)
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox81 | --- | unaffected |
firefox82 | --- | fixed |
firefox83 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Regression, )
Details
(Keywords: regression, Whiteboard: [marionette-fission-mvp][simple], [wptsync upstream])
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
If there is a navigation to be observed by waitForNavigationCompleted the specified callback, which triggers the navigation, is actually never called when there are no page load events expected or the set page load strategy capability is None
. Instead it just returns a resolved promise:
This is a regression from bug 1612831.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Even in the case of no load event expected, or the page load strategy
as set to None the callback that triggers the navigation always has
to be called.
Depends on D91443
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f4806d53c46a [wdspec] Added test for WebDriver:ElementClick to open a link with target=_blank.. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/1d341cedbe03 [marionette] Always call navigation callback in waitForNavigationCompleted. r=marionette-reviewers,maja_zf
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25792 for changes under testing/web-platform/tests
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f4806d53c46a
https://hg.mozilla.org/mozilla-central/rev/1d341cedbe03
Upstream PR merged by moz-wptsync-bot
Assignee | ||
Comment 7•4 years ago
|
||
Comment on attachment 9177906 [details]
Bug 1667377 - [marionette] Always call navigation callback in waitForNavigationCompleted.
Beta/Release Uplift Approval Request
- User impact if declined: Various WebDriver navigation commands do not actually trigger the page load when there are no page load events expected (like opening a link in a new tab or in a different frame), or the navigation shouldn't be awaited for.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just adds the call to trigger the navigation under any situation.
- String changes made/needed: no
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Comment on attachment 9177906 [details]
Bug 1667377 - [marionette] Always call navigation callback in waitForNavigationCompleted.
marionette fix, approved for 82.0b6
Updated•4 years ago
|
Comment 9•4 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/5a328a1cad63
https://hg.mozilla.org/releases/mozilla-beta/rev/87c3574ff598
Updated•2 years ago
|
Description
•