Closed Bug 1667470 Opened 4 years ago Closed 4 years ago

Enable tab-to-search in Nightly

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
1

Tracking

()

VERIFIED FIXED
83 Branch
Iteration:
83.1 - Sept 21 - Oct 4
Tracking Status
firefox83 --- verified

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

The pref to enable is browser.urlbar.update2.tabToComplete. We also need to have the feature approved by Product first.

There might be a fair number of tests to update. Any test that installs a test engine then autofills example.com will probably have to be updated. Most test engines have the template http(s)://example.com/?q={searchTerms} and so a tab-to-search result will be served.

Severity: -- → S3
Priority: P2 → P1

Product says this is good to go in Nightly.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 83.2 - Oct 5 - Oct 18
Iteration: 83.2 - Oct 5 - Oct 18 → 83.1 - Sept 21 - Oct 4
Points: 2 → 1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

We can confirm the feature is enabled on Nightly. We verified using Fx 83.0a1 (2020-10-13), on Windows 10 x64 and macOS 10.13.

Status: RESOLVED → VERIFIED

I love this feature, thank you for adding it. This will be a big productivity booster for me.

However there is a somewhat annoying new change which seems to be related to this one.

Consider the following workflow:

  1. Type a search query in the address bar.
  2. Hit [down arrow] repeatedly until one of the search engine icons at the bottom is highlighted (next to "This time, search with:")
  3. Hit Enter.
  4. Notice how the search doesn't get initiated until you now hit enter a second time. Previously that was not the case, you'd only have to hit enter once.

Thanks for reading.

Shawn

Thanks for the feedback. You can hold Shift when you click/press Enter on a one-off button to execute a search immediately. We're going note this override in the 83 release notes to make people aware of it. See bug 1671815 comment 1.

That works just fine for me, thanks for the advice.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: