Enable tab-to-search in Nightly
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox83 | --- | verified |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The pref to enable is browser.urlbar.update2.tabToComplete
. We also need to have the feature approved by Product first.
There might be a fair number of tests to update. Any test that installs a test engine then autofills example.com
will probably have to be updated. Most test engines have the template http(s)://example.com/?q={searchTerms}
and so a tab-to-search result will be served.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Product says this is good to go in Nightly.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Initial try run of the urlbar
tests with tab-to-search enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=11aba1fd9802ecbc5938723cb6e284a9acbc3dbe https://treeherder.mozilla.org/#/jobs?repo=try&revision=4653871a07cc99253f69c48347245b72b3275b2e
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Comment 6•4 years ago
|
||
bugherder |
Comment 7•4 years ago
|
||
We can confirm the feature is enabled on Nightly. We verified using Fx 83.0a1 (2020-10-13), on Windows 10 x64 and macOS 10.13.
I love this feature, thank you for adding it. This will be a big productivity booster for me.
However there is a somewhat annoying new change which seems to be related to this one.
Consider the following workflow:
- Type a search query in the address bar.
- Hit [down arrow] repeatedly until one of the search engine icons at the bottom is highlighted (next to "This time, search with:")
- Hit Enter.
- Notice how the search doesn't get initiated until you now hit enter a second time. Previously that was not the case, you'd only have to hit enter once.
Thanks for reading.
Shawn
Assignee | ||
Comment 9•4 years ago
|
||
Thanks for the feedback. You can hold Shift when you click/press Enter on a one-off button to execute a search immediately. We're going note this override in the 83 release notes to make people aware of it. See bug 1671815 comment 1.
Comment 10•4 years ago
|
||
That works just fine for me, thanks for the advice.
Description
•