Open
Bug 1667729
Opened 4 years ago
Updated 4 years ago
Large number of unreachable-code warnings in gl.cc (triggered from build.rs)
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox83 | --- | disabled |
People
(Reporter: janerik, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/plain
|
Details |
The assert
code in gfx/wr/swgl/src/gl.cc
is triggering a bunch of unreachable-code
warnings.
That file is compiled from gfx/wr/swgl/build.rs
and thus warnings are not caught by mach
.
A bit annoying if one tries to find their own errors and warnings in the output.
We should probably silence those warnings.
Updated•4 years ago
|
Blocks: sw-wr
Severity: -- → S3
status-firefox83:
--- → disabled
OS: Unspecified → All
Hardware: Unspecified → All
Reporter | ||
Comment 1•4 years ago
|
||
Locally I applied this just to stop it from annoying me right now:
diff --git gfx/wr/swgl/build.rs gfx/wr/swgl/build.rs
index 62c09ba7f310b..894079799d722 100644
--- gfx/wr/swgl/build.rs
+++ gfx/wr/swgl/build.rs
@@ -143,6 +143,7 @@ fn main() {
.flag("-fno-exceptions")
.flag("-fno-rtti")
.flag("-fno-math-errno")
+ .flag("-Wno-unreachable-code")
.define("_GLIBCXX_USE_CXX11_ABI", Some("0"))
.include(shader_dir)
.include("src")
You need to log in
before you can comment on or make changes to this bug.
Description
•