Use reference count for ScriptStencil.immutableScriptData
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Regressed 1 open bug)
Details
Attachments
(4 files)
If we want to keep ScriptStencil after instantiation (for off-thread encoding, or cache), instantiation shouldn't steal ScriptStencil.immutableScriptData.
instantiation moves the field into js::RuntimeScriptData.isd_, and js::RuntimeScriptData already has reference count.
We could use js::RuntimeScriptData for ScriptStencil.immutableScriptData, or make it variant.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D91923
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D91924
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D91925
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/80ddf8c23278
https://hg.mozilla.org/mozilla-central/rev/232b437d7a36
https://hg.mozilla.org/mozilla-central/rev/e0e696f32022
https://hg.mozilla.org/mozilla-central/rev/8a73f3d643d4
|
|
||
Comment 8•4 years ago
|
||
Backed out for causing Bug 1668489.
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=8a73f3d643d45b5022d63cba2279710335d3202d&searchStr=hazard
Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=317255015&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=317257686&repo=mozilla-central
Backout link: https://hg.mozilla.org/integration/autoland/rev/2224900e3db5d978e2b2207336a6cfa412595ded
|
|
||
Comment 10•4 years ago
|
||
Relanded this cause the backout didn't solve anything: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Jd7hyjiQQH2l0nVED1UaFg.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=2224900e3db5d978e2b2207336a6cfa412595ded&searchStr=linux%2Cx64%2Cdebug%2Cspidermonkey%2Cbuilds%2Chazard-linux64-shell-haz%2Fdebug%2Ch
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5e3005ef440a
https://hg.mozilla.org/mozilla-central/rev/330a87688dff
https://hg.mozilla.org/mozilla-central/rev/873b133c7f62
https://hg.mozilla.org/mozilla-central/rev/249ddc3a4e92
Description
•