1668210 - Prevent print settings being saved to unprefixed prefs on non-Android

Assignee

Description

•

4 years ago

Bug 1667509 comment 9 indicates that at some point we had misbehaving code that was saving print settings to prefs without a printer prefix. Given the potential for corrupting user prefs and likely making printing misbehave or even stop working, it seems like we should block this from happening in the platform code. We should probably also have a MOZ_DIAGNOSTIC_ASSERT to make sure if anyone adds such code again we notice and fix it ASAP.

Jonathan Watt [:jwatt]

Assignee

Comment 1

•

4 years ago

Attached file Bug 1668210. Prevent print settings being saved to unprefixed prefs on non-Android. r=bobowen (deleted) — Details

Pulsebot

Comment 2

•

4 years ago

Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/0028834844d2
Prevent print settings being saved to unprefixed prefs on non-Android. r=bobowen

Natalia Csoregi [:nataliaCs]

Comment 3

•

4 years ago

Backed out for web platform failures on delayed_window_print.html

backout: https://hg.mozilla.org/integration/autoland/rev/54572387507b04b9a1aed6cc7ffc478f055593b0

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0028834844d210d65c3936824c4946e3921804ea

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317142938&repo=autoland&lineNumber=3631

[task 2020-09-30T11:15:01.494Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.495Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.496Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.497Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.498Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.499Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.500Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.501Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.502Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.503Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.504Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.505Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.506Z] 11:15:01 [task 2020-09-30T11:15:01.507Z] 11:15:01 [task 2020-09-30T11:15:01.507Z] 11:15:01 [task 2020-09-30T11:15:01.507Z] 11:15:01 INFO - PROCESS-CRASH | /_mozilla/dom/delayed_window_print.html | application crashed [@ nsPrintSettingsService::SavePrintSettingsToPrefs(nsIPrintSettings*, bool, unsigned int)]
INFO - Mozilla crash reason: MOZ_DIAGNOSTIC_ASSERT(false) (Print settings must be saved with a prefix)
INFO - Crash dump filename: c:\users\task_1601459927\appdata\local\temp\tmpbgpgii\minidumps\bc401475-23b2-4eda-8b6e-9bcc997680db.dmp
INFO - Operating system: Windows NT
INFO - 10.0.17134
INFO - CPU: amd64
INFO - family 6 model 94 stepping 3
INFO - 8 CPUs
INFO -
INFO - GPU: UNKNOWN
INFO -
INFO - Crash reason: EXCEPTION_BREAKPOINT
INFO - Crash address: 0x838f7c5d
INFO - Process uptime: 5 seconds
INFO -
INFO - Thread 0 (crashed)
INFO - 0 xul.dll!nsPrintSettingsService::SavePrintSettingsToPrefs(nsIPrintSettings*, bool, unsigned int) [nsPrintSettingsService.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 1007 + 0x0]
INFO - rax = 0x00007ffd871c853b rdx = 0x000001ff8f4c000d
INFO - rcx = 0x00007ffdb16cc8c8 rbx = 0x000000001a5fde01
INFO - rsi = 0x000000a71a5fe000 rdi = 0x000001ff8f4c8830
INFO - rbp = 0x0000000000000000 rsp = 0x000000a71a5fde70
INFO - r8 = 0x0000000000000000 r9 = 0x00000000ffffffff
INFO - r10 = 0x0000000000000000 r11 = 0x4551011451455400
INFO - r12 = 0x000001ff8bd93a60 r13 = 0x000001ff8f98adb8
INFO - r14 = 0x000001ff8f495f60 r15 = 0x00000000ffffffff
INFO - rip = 0x00007ffd838f7c5d
INFO - Found by: given as instruction pointer in context
INFO - 1 xul.dll!mozilla::embedding::PrintingParent::RecvSavePrintSettings(mozilla::embedding::PrintData const&, bool const&, unsigned int const&, nsresult*) [PrintingParent.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 197 + 0xd]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fdf70 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd84b4d2c1
INFO - Found by: call frame info
INFO - 2 xul.dll!mozilla::embedding::PPrintingParent::OnMessageReceived(IPC::Message const&, IPC::Message*&) [PPrintingParent.cpp: : 639 + 0x32]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fdfd0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd81a168bc
INFO - Found by: call frame info
INFO - 3 xul.dll!mozilla::dom::PContentParent::OnMessageReceived(IPC::Message const&, IPC::Message*&) [PContentParent.cpp: : 14737 + 0x13]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fe2b0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd81929c14
INFO - Found by: call frame info
INFO - 4 xul.dll!mozilla::ipc::MessageChannel::DispatchSyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&, IPC::Message*&) [MessageChannel.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 2119 + 0x13]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fe510 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd81855c8a
INFO - Found by: call frame info
INFO - 5 xul.dll!mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [MessageChannel.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 2070 + 0xe]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fe5c0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd8185501d
INFO - Found by: call frame info
INFO - 6 xul.dll!mozilla::ipc::MessageChannel::MessageTask::Run() [MessageChannel.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 1953 + 0xc]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fe6b0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd81855912
INFO - Found by: call frame info
INFO - 7 xul.dll!mozilla::RunnableTask::Run() [TaskController.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 244 + 0xd]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fe6f0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd813049d7
INFO - Found by: call frame info
INFO - 8 xul.dll!mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex &> const&) [TaskController.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 514 + 0x10]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5feb80 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd812eef59
INFO - Found by: call frame info
INFO - 9 xul.dll!mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex &> const&) [TaskController.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 373 + 0x5]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fecf0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd812ee111
INFO - Found by: call frame info
INFO - 10 xul.dll!mozilla::TaskController::ProcessPendingMTTask(bool) [TaskController.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 170 + 0x8]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fed60 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd812ee24c
INFO - Found by: call frame info
INFO - 11 xul.dll!mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:84:7'>::Run() [nsThreadUtils.h:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 577 + 0xe]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fede0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd81307592
INFO - Found by: call frame info
INFO - 12 xul.dll!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 1234 + 0xd]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5fee10 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd812f9619
INFO - Found by: call frame info
INFO - 13 xul.dll!NS_ProcessNextEvent(nsIThread*, bool) [nsThreadUtils.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 513 + 0x14]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff3e0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd812fca65
INFO - Found by: call frame info
INFO - 14 xul.dll!mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [MessagePump.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 87 + 0xa]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff430 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd81858076
INFO - Found by: call frame info
INFO - 15 xul.dll!MessageLoop::RunHandler() [message_loop.cc:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 327 + 0x16]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff490 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd81824070
INFO - Found by: call frame info
INFO - 16 xul.dll!MessageLoop::Run() [message_loop.cc:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 309 + 0x5]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff4e0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd81823fe8
INFO - Found by: call frame info
INFO - 17 xul.dll!nsBaseAppShell::Run() [nsBaseAppShell.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 137 + 0xd]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff530 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd838e83d8
INFO - Found by: call frame info
INFO - 18 xul.dll!nsAppShell::Run() [nsAppShell.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 602 + 0x8]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff570 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd8396abec
INFO - Found by: call frame info
INFO - 19 xul.dll!nsAppStartup::Run() [nsAppStartup.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 270 + 0xd]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff6e0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd84abcef7
INFO - Found by: call frame info
INFO - 20 xul.dll!XREMain::XRE_mainRun() [nsAppRunner.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 4896 + 0xd]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff730 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd84b7ba3e
INFO - Found by: call frame info
INFO - 21 xul.dll!XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 5088 + 0x8]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ff9d0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd84b7cf69
INFO - Found by: call frame info
INFO - 22 xul.dll!XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 5145 + 0x10]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ffa90 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffd84b7d2cc
INFO - Found by: call frame info
INFO - 23 firefox.exe!NS_internal_main(int, char**, char**) [nsBrowserApp.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 336 + 0xa0]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ffbf0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ff6b8c317cd
INFO - Found by: call frame info
INFO - 24 firefox.exe!wmain(int, wchar_t**) [nsWindowsWMain.cpp:fd5aa1efcfdd3bd7261fd3a2399e392c79ea9988 : 131 + 0x15]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ffdc0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ff6b8c311fe
INFO - Found by: call frame info
INFO - 25 firefox.exe!__scrt_common_main_seh() [exe_common.inl : 288 + 0x22]
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ffe80 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ff6b8c8ae38
INFO - Found by: call frame info
INFO - 26 kernel32.dll!BaseThreadInitThunk + 0x14
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ffec0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffdbe2b3034
INFO - Found by: call frame info
INFO - 27 ntdll.dll!SdbpCheckMatchingFiles + 0x81
INFO - rbx = 0x000000001a5fde01 rbp = 0x0000000000000000
INFO - rsp = 0x000000a71a5ffef0 r12 = 0x000001ff8bd93a60
INFO - r13 = 0x000001ff8f98adb8 r14 = 0x000001ff8f495f60
INFO - r15 = 0x00000000ffffffff rip = 0x00007ffdbf7b1461
INFO - Found by: call frame info
INFO -

Flags: needinfo?(jwatt)

Natalia Csoregi [:nataliaCs]

Comment 4

•

4 years ago

Another failure:

Jonathan Watt [:jwatt]

Assignee

Updated

•

4 years ago

Flags: needinfo?(jwatt)

Jonathan Watt [:jwatt]

Assignee

Updated

•

4 years ago

Whiteboard: [print2020_v83] → [print2020_v85]

Jonathan Watt [:jwatt]

Assignee

Updated

•

4 years ago

Whiteboard: [print2020_v85] → [print2020_v84]

BugBot [:suhaib / :marco/ :calixte]

Comment 5

•

4 years ago

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jwatt, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(jwatt)

Sean Voisen (:svoisen)

Updated

•

4 years ago

Whiteboard: [print2020_v84] → [print2020_v85]

Jonathan Watt [:jwatt]

Assignee

Updated

•

4 years ago

Flags: needinfo?(jwatt)

Whiteboard: [print2020_v85] → [print2020_v88]

Jonathan Watt [:jwatt]

Assignee

Updated

•

3 years ago

Whiteboard: [print2020_v88] → [print2020]

Jonathan Watt [:jwatt]

Assignee

Updated

•

2 years ago

Depends on: 1756447

Jonathan Watt [:jwatt]

Assignee

Comment 6

•

2 years ago

Now that bug 1756447 has landed this can reland.

Pulsebot

Comment 7

•

2 years ago

Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/ebfc859bf431
Prevent print settings being saved to unprefixed prefs on non-Android. r=bobowen

Atila Butkovits

Comment 8

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ebfc859bf431

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox101: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 101 Branch

Bugzilla

Quick Search

Prevent print settings being saved to unprefixed prefs on non-Android

Categories

(Core :: Printing: Setup, task, P2)

Tracking

()

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Whiteboard: [print2020])

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Updated

Updated

Updated

Comment 5

Updated

Updated

Updated

Updated

Comment 6

Comment 7

Comment 8

Attachment

General

Description

File Name

Content Type