Since updating mozilla-central today, I get the following error when building:

 1:09.62    Compiling netwerk_helper v0.0.1 (/home/simon/work/refactor/netwerk/base/rust-helper)
 1:09.90 error: `extern` fn uses type `for<'r> fn(&'r ThinVec<nsCString>) -> bool`, which is not FFI-safe
 1:09.90    --> netwerk/base/rust-helper/src/lib.rs:323:76
 1:09.90     |
 1:09.90 323 | pub extern "C" fn rust_parse_etc_hosts<'a>(path: &'a nsACString, callback: ParsingCallback) {
 1:09.90     |                                                                            ^^^^^^^^^^^^^^^ not FFI-safe
 1:09.90     |
 1:09.91     = note: `-D improper-ctypes-definitions` implied by `-D warnings`
 1:09.91     = help: consider using an `extern fn(...) -> ...` function pointer instead
 1:09.91     = note: this function pointer has Rust-specific calling convention
 1:09.91 error: aborting due to previous error
 1:09.92 error: could not compile `netwerk_helper`

I did rustup update but it didn't fix this.

FWIW, I am using rust Nightly.

Valentin, is it possible to make this work with Rust nightly as well?

Using extern fn is needed to avoid a warning, but also this avoids copying the
filename when it's already valid utf-8, and makes some other minor cosmetic
tweaks, like removing useless move in lambdas and so on.

All these functions use snake case so they're not needed.

Depends on D92182

No need to cast a byte as a char to test it against ascii characters.

Depends on D92183

Emilio is blazing fast 🙂
Thanks a lot for fixing this so quickly. My compiler was just warming up.

Set release status flags based on info from the regressing bug 1616252

https://hg.mozilla.org/mozilla-central/rev/1d7ff6f2d3ae
https://hg.mozilla.org/mozilla-central/rev/fb2e42f334c6
https://hg.mozilla.org/mozilla-central/rev/37cd0824dd4b