Missing brighttext attribute for toolbars inside dialog windows
Categories
(Thunderbird :: Theme, defect, P2)
Tracking
(thunderbird_esr68 unaffected, thunderbird_esr78? fixed, thunderbird82? fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr68 | --- | unaffected |
| thunderbird_esr78 | ? | fixed |
| thunderbird82 | ? | fixed |
People
(Reporter: aleca, Assigned: aleca)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
darktrojan
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
For those windows that don't have a #tabmail element, the brighttext attribute is not properly set when initialized.
List of windows:
- Composer
- Address Book
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
let's use the toolbox element to be sure we have toolbars to deal with.
|
|
Assignee | |
Comment 3•4 years ago
|
||
(In reply to alta88 from comment #2)
Will this fix the missing
brighttexton thetabbar-toolbar?
No, this is a fix for another issue.
It seems like the current selector let toolbarSelector = "toolbox > toolbar:not([collapsed=true])"; doesn't consider toolbars indented in other toolbars, which is what the tabbar-toolbar is, being inside the tabs-toolbar.
Is there an issue opened for this? Does that child toolbar need the birghttext attribute? Do we have other similar situation with nested toolbars?
|
||
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3ff58d971f5a
Fix missing brighttext attribute for toolbars inside dialog windows. r=darktrojan
|
|
||
Updated•4 years ago
|
(In reply to Alessandro Castellani (:aleca) from comment #3)
(In reply to alta88 from comment #2)
Will this fix the missing
brighttexton thetabbar-toolbar?No, this is a fix for another issue.
It seems like the current selector
let toolbarSelector = "toolbox > toolbar:not([collapsed=true])";doesn't consider toolbars indented in other toolbars, which is what thetabbar-toolbaris, being inside thetabs-toolbar.Is there an issue opened for this? Does that child toolbar need the birghttext attribute? Do we have other similar situation with nested toolbars?
unknown; yes; unknown. I will leave it to you to fix/followup, thanks.
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9179361 [details] [diff] [review]
1668896-brighttext-attribute.diff
[Approval Request Comment]
Regression caused by (bug #): bug 1638233
User impact if declined: Composer, Address Book darktheme issues
|
||
Comment 7•4 years ago
|
||
Comment on attachment 9179361 [details] [diff] [review]
1668896-brighttext-attribute.diff
[Triage Comment]
Approved for beta
|
||
Comment 8•4 years ago
|
||
| bugherder uplift | ||
Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a2762c45c863
|
||
Comment 11•4 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #6)
Comment on attachment 9179361 [details] [diff] [review]
1668896-brighttext-attribute.diff[Approval Request Comment]
Regression caused by (bug #): bug 1638233
User impact if declined: Composer, Address Book darktheme issues
Further notable impact: Unreadable entries in email list when switching from dark mode to light mode (bug 1668989)
|
|
||
Comment 12•4 years ago
|
||
Comment on attachment 9179361 [details] [diff] [review]
1668896-brighttext-attribute.diff
[Triage Comment]
Approved for esr78
|
|
||
Comment 13•4 years ago
|
||
| bugherder uplift | ||
Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/f6e50c2d79c7
Description
•