Closed Bug 1669117 Opened 4 years ago Closed 4 years ago

Intermittent TV toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html | Check autoMaskingEnabled: After fill - true == false | Unmasked to the end: After fill - 0 == 15

Categories

(Toolkit :: Password Manager, defect, P5)

defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=317545855&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/KQZ-kzi3TdqAA8hHSQLqAA/runs/0/artifacts/public/logs/live_backing.log


[task 2020-10-04T21:10:17.682Z] 21:10:17     INFO - TEST-START | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html
[task 2020-10-04T21:10:21.282Z] 21:10:21     INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html | Check generated password format 
[task 2020-10-04T21:10:21.282Z] 21:10:21     INFO - Buffered messages finished
[task 2020-10-04T21:10:21.284Z] 21:10:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html | Check autoMaskingEnabled: After fill - true == false 
[task 2020-10-04T21:10:21.284Z] 21:10:21     INFO - {u'columnNumber': 12, u'formattedStack': u'checkPasswordMasked@resource://testing-common/LoginTestUtils.jsm:542:12\ndoApply@resource://specialpowers/WrapPrivileged.jsm:118:18\napply/<@resource://specialpowers/WrapPrivileged.jsm:260:30\nwrapExceptions@resource://specialpowers/WrapPrivileged.jsm:206:12\napply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 18, u'formattedStack': u'doApply@resource://specialpowers/WrapPrivileged.jsm:118:18\napply/<@resource://specialpowers/WrapPrivileged.jsm:260:30\nwrapExceptions@resource://specialpowers/WrapPrivileged.jsm:206:12\napply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 30, u'formattedStack': u'apply/<@resource://specialpowers/WrapPrivileged.jsm:260:30\nwrapExceptions@resource://specialpowers/WrapPrivileged.jsm:206:12\napply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 12, u'formattedStack': u'wrapExceptions@resource://specialpowers/WrapPrivileged.jsm:206:12\napply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 12, u'formattedStack': u'apply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 21, u'formattedStack': u'testConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': None, u'name': u'testConfirmPasswordFieldFilledWithGeneratedPassword', u'sourceLine': u'', u'sourceId': 226, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html', u'lineNumber': 158, u'asyncCaller': None}, u'name': u'apply', u'sourceLine': u'', u'sourceId': 46, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://specialpowers/WrapPrivileged.jsm', u'lineNumber': 244, u'asyncCaller': None}, u'name': u'wrapExceptions', u'sourceLine': u'', u'sourceId': 46, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://specialpowers/WrapPrivileged.jsm', u'lineNumber': 206, u'asyncCaller': None}, u'name': u'apply/<', u'sourceLine': u'', u'sourceId': 46, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://specialpowers/WrapPrivileged.jsm', u'lineNumber': 260, u'asyncCaller': None}, u'name': u'doApply', u'sourceLine': u'', u'sourceId': 46, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://specialpowers/WrapPrivileged.jsm', u'lineNumber': 118, u'asyncCaller': None}, u'name': u'checkPasswordMasked', u'sourceLine': u'', u'sourceId': 71, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://testing-common/LoginTestUtils.jsm', u'lineNumber': 542, u'asyncCaller': None}
[task 2020-10-04T21:10:21.284Z] 21:10:21     INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html | unmaskedStart is 0: After fill - 0 == 0 
[task 2020-10-04T21:10:21.284Z] 21:10:21     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-04T21:10:21.289Z] 21:10:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html | Unmasked to the end: After fill - 0 == 15 
[task 2020-10-04T21:10:21.289Z] 21:10:21     INFO - {u'columnNumber': 14, u'formattedStack': u'checkPasswordMasked@resource://testing-common/LoginTestUtils.jsm:551:14\ndoApply@resource://specialpowers/WrapPrivileged.jsm:118:18\napply/<@resource://specialpowers/WrapPrivileged.jsm:260:30\nwrapExceptions@resource://specialpowers/WrapPrivileged.jsm:206:12\napply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 18, u'formattedStack': u'doApply@resource://specialpowers/WrapPrivileged.jsm:118:18\napply/<@resource://specialpowers/WrapPrivileged.jsm:260:30\nwrapExceptions@resource://specialpowers/WrapPrivileged.jsm:206:12\napply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 30, u'formattedStack': u'apply/<@resource://specialpowers/WrapPrivileged.jsm:260:30\nwrapExceptions@resource://specialpowers/WrapPrivileged.jsm:206:12\napply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 12, u'formattedStack': u'wrapExceptions@resource://specialpowers/WrapPrivileged.jsm:206:12\napply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 12, u'formattedStack': u'apply@resource://specialpowers/WrapPrivileged.jsm:244:12\ntestConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': {u'columnNumber': 21, u'formattedStack': u'testConfirmPasswordFieldFilledWithGeneratedPassword@https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html:158:21\n', u'caller': None, u'name': u'testConfirmPasswordFieldFilledWithGeneratedPassword', u'sourceLine': u'', u'sourceId': 226, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'https://example.com/tests/toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html', u'lineNumber': 158, u'asyncCaller': None}, u'name': u'apply', u'sourceLine': u'', u'sourceId': 46, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://specialpowers/WrapPrivileged.jsm', u'lineNumber': 244, u'asyncCaller': None}, u'name': u'wrapExceptions', u'sourceLine': u'', u'sourceId': 46, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://specialpowers/WrapPrivileged.jsm', u'lineNumber': 206, u'asyncCaller': None}, u'name': u'apply/<', u'sourceLine': u'', u'sourceId': 46, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://specialpowers/WrapPrivileged.jsm', u'lineNumber': 260, u'asyncCaller': None}, u'name': u'doApply', u'sourceLine': u'', u'sourceId': 46, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://specialpowers/WrapPrivileged.jsm', u'lineNumber': 118, u'asyncCaller': None}, u'name': u'checkPasswordMasked', u'sourceLine': u'', u'sourceId': 71, u'asyncCause': None, u'nativeSavedFrame': {}, u'filename': u'resource://testing-common/LoginTestUtils.jsm', u'lineNumber': 551, u'asyncCaller': None}
[task 2020-10-04T21:10:21.289Z] 21:10:21     INFO - Check the expected password fields are filled
[task 2020-10-04T21:10:21.289Z] 21:10:21     INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html | Field (uname) field has the expected value ```
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Regressed by: 1690358
Summary: Intermittent toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html | Check autoMaskingEnabled: After fill - true == false | Unmasked to the end: After fill - 0 == 15 → Intermittent TV toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation_confirm.html | Check autoMaskingEnabled: After fill - true == false | Unmasked to the end: After fill - 0 == 15
Has Regression Range: --- → yes
Keywords: regression
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

It seems that focus change has occurred after generating a password because nsIEditor.unmask(0) is the only callsite, this means that we don't use auto masking, so, nsIEditor.mask() must have been called explicitly. It's also called only by here, and the function is called when focus move except user input or another autocomplete.

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.