New UI has saved invalid margins to prefs, causing print preview to become completely disabled and unusable
Categories
(Toolkit :: Printing, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox81 | --- | unaffected |
| firefox82 | --- | wontfix |
| firefox83 | --- | verified |
People
(Reporter: julienw, Assigned: emmamalysz)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [print2020_v83][old-ui-])
Attachments
(2 files)
Capture d’écran de 2020-10-05 11-20-11.png
STR:
- Set some margin values to a negative value (eg: set to
-1) - Try to print preview.
=> The print preview is all disabled, without any clear information about how to resolve the issue.
Only when opening the "more settings" dropdown that the user can see the margin is invalid, and can resolve it.
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Comment 1•4 years ago
|
||
BTW I also that believe the "Printer" select shouldn't be disabled. Indeed the bogus values are per-printer and so we should be able to change the printer. Especially in this case I was interested in the feature "save as PDF" but couldn't even select it.
|
||
Comment 2•4 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #0)
- Set some margin values to a negative value (eg: set to
-1)
Did you do this by setting them in about:config, or some other way?
(In reply to Julien Wajsberg [:julienw] from comment #1)
BTW I also that believe the "Printer" select shouldn't be disabled.
Can you report that as a separate bug?
|
|
Reporter | |
Comment 3•4 years ago
|
||
(In reply to Jonathan Watt [:jwatt] from comment #2)
(In reply to Julien Wajsberg [:julienw] from comment #0)
- Set some margin values to a negative value (eg: set to
-1)Did you do this by setting them in
about:config, or some other way?
No I get these weird values without setting them manually. I mozregressed and found that the last patch in bug 1663503 got me these values (I commented there too).
(In reply to Julien Wajsberg [:julienw] from comment #1)
BTW I also that believe the "Printer" select shouldn't be disabled.
Can you report that as a separate bug?
Sure, I filed bug 1669225.
|
|
||
Comment 4•4 years ago
|
||
Ah, thanks. And thanks for filing that other bug.
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 5•4 years ago
|
||
If margins are manually set to negative entries or if the selected printer
had bad values, we need to correctly reset the pref value to valid default
margins.
|
|
||
Comment 6•4 years ago
|
||
FWIW in bug 1669370 I've landed a patch to reject obviously bad setting in platform code when reading them from prefs (i.e. under initPrintSettingsFromPrefs()).
|
||
Comment 7•4 years ago
|
||
Set release status flags based on info from the regressing bug 1663503
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
I am unable to save invalid margins using the french 83.0b2 build across-platforms. Confirming the fix.
|
|
||
Updated•4 years ago
|
Description
•