Closed
Bug 1669383
Opened 4 years ago
Closed 4 years ago
Test both webgl.out-of-process:true and false
Categories
(Core :: Graphics: CanvasWebGL, task, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
While we're flip-flopping the pref, we want both paths tested.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4fda6445b65
Force default mochitest-webgl runs to use webgl.out-of-process:false. r=ahal
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
|
||
Comment 4•3 years ago
|
||
I noticed on some runs (like win10-asan m-gli(mda)) that we have both:
--setpref=webgl.out-of-process=false
--setpref=webgl.out-of-process=true
this is set for any webgl-ipc variant:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests.py#285
I would like to confirm that this is expected.
Flags: needinfo?(jgilbert)
|
|
Assignee | |
Comment 5•3 years ago
|
||
I'm expecting the variant to override the test settings. Is that right?
Flags: needinfo?(jgilbert) → needinfo?(jmaher)
|
|
||
Comment 6•3 years ago
|
||
so I think the test defaults to false, then the -gli variant adds a true. The question is does that result in what we expect- the answer is yes. Because the True comes later in the commandline arguments, it overrides the False setting.
Flags: needinfo?(jmaher)
|
|
Assignee | |
Comment 7•3 years ago
|
||
Great, sounds right to me too!
You need to log in
before you can comment on or make changes to this bug.
Description
•