Switch Windows code coverage builds to WebRender
Categories
(Testing :: Code Coverage, enhancement)
Tracking
(firefox84 fixed)
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: kats)
References
(Regressed 1 open bug)
Details
Attachments
(2 files)
On Nightly the vast majority of our users are on WebRender we should switch the code coverage builds over so that we get WebRender code coverage information.
Assignee | ||
Comment 1•4 years ago
|
||
Maybe this will do what we want. Maybe some tests will fail because we never bothered to get them passing with WR.
Assignee | ||
Comment 2•4 years ago
|
||
Hm, looking at some of the test logs there I don't think it actually enabled webrender. I'll take another stab at it. Might be running on the wrong hardware.
Assignee | ||
Comment 3•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=b0880e910fdfc9cb894992daca1615facde2220a is looking better. I just did reftests on this one but they seem to be getting webrender enabled. I can add more test jobs in a bit.
Assignee | ||
Comment 4•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=674a0a5a3c935c440df3efbef15c441de2966619 should have the jit-tests and web-platform-reftest failures addressed.
Assignee | ||
Comment 5•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=048802107c88ae4304d222c3df2b41855a662040 should be a better set of patches. As far as I can tell from previous try runs this should end up green enough to land, although it will also include jobs that fail but won't run on m-c (e.g. fission variant of mochitest-gpu-chrome). I couldn't find a way to get a push with an "m-c simulation" set of jobs, I had to use ./mach try fuzzy --full
with a win10+ccov selector which picked up jobs that normally get filtered out.
Comment 6•4 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)
I couldn't find a way to get a push with an "m-c simulation" set of jobs, I had to use
./mach try fuzzy --full
with a win10+ccov selector which picked up jobs that normally get filtered out.
You should be able to do that if you remove this line https://searchfox.org/mozilla-central/rev/e1d1f043957191616721b9e8bf811c0aab8a203a/taskcluster/taskgraph/target_tasks.py#39.
Assignee | ||
Comment 7•4 years ago
|
||
Ah, thanks, I should have realized that! I cancelled the above try push and started a new one:
Assignee | ||
Comment 8•4 years ago
|
||
We never actually run anything on this test platform, we only run opt.
Depends on D94725
Updated•4 years ago
|
Assignee | ||
Comment 9•4 years ago
|
||
This moves most of the windows ccov tests to run with WebRender enabled by
putting them in the windows10-64-ccov-qr test platform. (The -qr suffix causes
the taskgraph code to enable WebRender for these jobs).
The only one skipped is the marionette GPU test because it contains a test that
specifically requires WebRender disabled.
The existing non-regex config keys that referred to windows10-64-ccov
also
get updated, and in a couple of places we need to add a new non-regex key to
disambiguate between two matching regex keys.
Depends on D94768
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
Backed out for linting failure on tests.py
Backout link: https://hg.mozilla.org/integration/autoland/rev/fec68b2b0546c20303b18d9aec40f5a5d3e463cb
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=320036027&repo=autoland&lineNumber=133
Assignee | ||
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Comment 13•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e0ec2bbd1b15
https://hg.mozilla.org/mozilla-central/rev/a24fccf92bf6
Description
•