Closed Bug 1669478 Opened 4 years ago Closed 4 years ago

Switch Windows code coverage builds to WebRender

Categories

(Testing :: Code Coverage, enhancement)

Default
enhancement

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: jrmuizel, Assigned: kats)

References

(Regressed 1 open bug)

Details

Attachments

(2 files)

On Nightly the vast majority of our users are on WebRender we should switch the code coverage builds over so that we get WebRender code coverage information.

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=0ee5591547836b266e3448846df91838fa2f8252

Maybe this will do what we want. Maybe some tests will fail because we never bothered to get them passing with WR.

Hm, looking at some of the test logs there I don't think it actually enabled webrender. I'll take another stab at it. Might be running on the wrong hardware.

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=b0880e910fdfc9cb894992daca1615facde2220a is looking better. I just did reftests on this one but they seem to be getting webrender enabled. I can add more test jobs in a bit.

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=048802107c88ae4304d222c3df2b41855a662040 should be a better set of patches. As far as I can tell from previous try runs this should end up green enough to land, although it will also include jobs that fail but won't run on m-c (e.g. fission variant of mochitest-gpu-chrome). I couldn't find a way to get a push with an "m-c simulation" set of jobs, I had to use ./mach try fuzzy --full with a win10+ccov selector which picked up jobs that normally get filtered out.

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)

I couldn't find a way to get a push with an "m-c simulation" set of jobs, I had to use ./mach try fuzzy --full with a win10+ccov selector which picked up jobs that normally get filtered out.

You should be able to do that if you remove this line https://searchfox.org/mozilla-central/rev/e1d1f043957191616721b9e8bf811c0aab8a203a/taskcluster/taskgraph/target_tasks.py#39.

Ah, thanks, I should have realized that! I cancelled the above try push and started a new one:

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=ecd5ecf1462e9b9f9b96a4e63863677c8942b4ad

We never actually run anything on this test platform, we only run opt.

Depends on D94725

Assignee: nobody → kats
Status: NEW → ASSIGNED

This moves most of the windows ccov tests to run with WebRender enabled by
putting them in the windows10-64-ccov-qr test platform. (The -qr suffix causes
the taskgraph code to enable WebRender for these jobs).
The only one skipped is the marionette GPU test because it contains a test that
specifically requires WebRender disabled.

The existing non-regex config keys that referred to windows10-64-ccov also
get updated, and in a couple of places we need to add a new non-regex key to
disambiguate between two matching regex keys.

Depends on D94768

Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56e6528b37eb Remove unused windows10-64-ccov/debug bits. r=ahal https://hg.mozilla.org/integration/autoland/rev/995156a1234a Enable WebRender on most of the windows10-64 ccov tests. r=ahal,jrmuizel
Flags: needinfo?(kats)
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0ec2bbd1b15 Remove unused windows10-64-ccov/debug bits. r=ahal https://hg.mozilla.org/integration/autoland/rev/a24fccf92bf6 Enable WebRender on most of the windows10-64 ccov tests. r=ahal,jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: