Closed Bug 1669807 Opened 4 years ago Closed 4 years ago

Permafailing condprof [tier 2] bash: virtualenv/virtualenv.py: Permission denied with Unsuccessful task run with exit code: 126

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox-esr78 fixed, firefox81 unaffected, firefox82 unaffected, firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox-esr78 --- fixed
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 --- fixed

People

(Reporter: nataliaCs, Assigned: rstewart)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=a42aa95147941ca7983eaf4846b644e207de24f8&searchStr=condprof&group_state=expanded

Failure log:

[task 2020-10-07T17:52:34.116Z] + adb install -r target.apk
[task 2020-10-07T17:52:34.116Z] Performing Streamed Install
[task 2020-10-07T17:52:34.116Z] Success
[task 2020-10-07T17:52:34.116Z] + rm -rf target.apk
[task 2020-10-07T17:52:34.116Z] + virtualenv/virtualenv.py -p python3 .
[task 2020-10-07T17:52:34.116Z] bash: virtualenv/virtualenv.py: Permission denied
[task 2020-10-07T17:52:34.116Z] script.py: command finished
[task 2020-10-07T17:52:34.116Z] script.py: enabling charging for device 'Moto G (5)' ('ZY322MQ7SV')...

[fetches 2020-10-07T17:53:25.649Z] finished fetching artifacts
[task 2020-10-07T17:53:25.649Z] executing ['bash', '-cx', 'virtualenv/virtualenv.py -p python3.7 . && bin/python3.7 condprof/main.py --geckodriver ${MOZ_FETCHES_DIR}/geckodriver --firefox ${MOZ_FETCHES_DIR}/firefox/firefox-bin --scenario settled ../../archive']in fetches/condprofile
[task 2020-10-07T17:53:25.651Z] + virtualenv/virtualenv.py -p python3.7 .
[task 2020-10-07T17:53:25.651Z] bash: virtualenv/virtualenv.py: Permission denied
[taskcluster 2020-10-07 17:53:26.000Z] === Task Finished ===
[taskcluster 2020-10-07 17:53:26.125Z] Artifact "public/condprof" not found at "/builds/worker/archive"
[taskcluster 2020-10-07 17:53:26.244Z] Unsuccessful task run with exit code: 126 completed in 99.839 seconds

:glandium this might be related to Bug 1654457 , could you take a few mins to check please?
Thank you.

Flags: needinfo?(mh+mozilla)

Bug 1654457 removed executable permissions from the virtualenv.py script. We can either re-add them or rewrite taskcluster/ci/condprof/kind.yml accordingly. The first is much lower-friction so I'll just do that really quick.

Bug 1654457 removed it, maybe accidentally. But its absence breaks condprof builds.

Assignee: nobody → rstewart
Status: NEW → ASSIGNED
Attachment #9180264 - Attachment description: Bug 1669807 - Add executable bit back to `virtualenv.py` → Bug 1669807 - Don't directly execute `virtualenv.py` in `condprof` scripts

Set release status flags based on info from the regressing bug 1654457

Pushed by rstewart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a9b795de6ee Don't directly execute `virtualenv.py` in `condprof` scripts r=glandium
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Flags: needinfo?(mh+mozilla)

Comment on attachment 9180264 [details]
Bug 1669807 - Don't directly execute virtualenv.py in condprof scripts

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Resolves condprof CI regression from 1654457.
  • User impact if declined: None, though CI will fail to run condprof tasks.
  • Fix Landed on Version: 83
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): condprof CI patch, won't affect users.
  • String or UUID changes made by this patch:
Attachment #9180264 - Flags: approval-mozilla-esr78?

Comment on attachment 9180264 [details]
Bug 1669807 - Don't directly execute virtualenv.py in condprof scripts

Needed to better support running mach on newer macOS releases. Approved for 78.8esr.

Attachment #9180264 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: