Open Bug 1669815 Opened 4 years ago Updated 4 years ago

Remove now-useless "aInRange" outparam from nsPrintJob::PrintPage (and simplify nsPagePrintTimer::StartTimer() which consumes it?)

Categories

(Core :: Printing: Output, task)

task

Tracking

()

People

(Reporter: dholbert, Unassigned)

References

Details

(Whiteboard: [print2020][old-ui-])

TYLin noticed in https://phabricator.services.mozilla.com/D92660#inline-525188 that the aInRange outparam for nsPrintJob::PrintPage is now becoming useless, now that print-ranges are handled earlier on (and every printed sheet is trivially "in range").

We should remove this outparam, and look into simplifying the code that consumed it (it seemed to be used for print-timer-duration calculations in
nsPagePrintTimer::Run() via nsPagePrintTimer::StartTimer()).

Depends on: 1661868
Whiteboard: [print2020_v84][old-ui-]
Whiteboard: [print2020_v84][old-ui-] → [print2020_v85][old-ui-]
Whiteboard: [print2020_v85][old-ui-] → [print2020_v87][old-ui-]
Whiteboard: [print2020_v87][old-ui-] → [print2020][old-ui-]
You need to log in before you can comment on or make changes to this bug.