Closed Bug 1669981 Opened 4 years ago Closed 3 years ago

fix logging and remove caplogpp pytest fixture (antenna)

Categories

(Socorro :: Antenna, task, P3)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

A while back, I reworked logging and in order to get tests to make assertions on things that were logged, I wrote a caplogpp test fixture which tweaks the "propagate" value on loggers.

Turns out that's all set up wrong and we shouldn't need to have a caplogpp at all.

This bug covers reworking the logging configuration:

  1. only the root logger specifies a handler
  2. the root logger sets the level to WARNING
  3. non-root loggers set propagate=True
  4. remove caplogpp (pretty sure we can remove it at this point)

I redid configuration for Antenna recently and in the process of doing that, I think I addressed items 1, 2, and 3. We still have item 4 to do.

Keywords: good-first-bug
Attached file pr 791: bug 1669981: remove caplogpp (deleted) —
Assignee: nobody → willkg
Status: NEW → ASSIGNED

I deployed this to prod in bug #1757737. Marking as FIXED.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: