Closed Bug 1669990 Opened 4 years ago Closed 4 years ago

Print preview closes if the "escape" keyboard button is pressed for dropdown menus

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Type:
defect

Tracking

(firefox82 wontfix, firefox83 wontfix, firefox84 wontfix, firefox85 verified, firefox86 verified)

Status:
VERIFIED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox82 --- wontfix
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- verified
firefox86 --- verified

People

(Reporter: emilghitta, Assigned: pbz)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1669990 - SubDialog: Use system event listener for escape key. r=gijs
(deleted), text/x-phabricator-request
Details

Affected versions

  • Firefox 83.0a1 (BuildId:20201008094950)
  • Firefox 82.0b8 (BuildId:20201006142214)

Affected platforms

  • Windows 10 64bit
  • Ubuntu 18.04 64bit
  • macOS 10.14

Steps to reproduce

  1. Launch Firefox.
  2. Access a random webpage.
  3. Open the print preview.
  4. Open a dropdown menu (ex: Paper Size, Margins, Destination,etc).
  5. While the dropdown menu is open, hit the escape keyboard button in order to close the dropdown menu.

Expected result

  • The dropdown menu in question is closed.

Actual result

  • The entire print preview gets closed.

Regression Window

  • I don’t think that this is a regression.

Additional Information

  • [Suggested severity] S3 or S4
  • As a side note, Chrome seems to align with the mentioned expected result.

Gijs, does this seem like something TabDialogBox should handle? There could be a bunch of edge cases here I'd imagine but I believe TabDialogBox would be the one closing the dialog.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Mark Striemer [:mstriemer] from comment #1)

Gijs, does this seem like something TabDialogBox should handle? There could be a bunch of edge cases here I'd imagine but I believe TabDialogBox would be the one closing the dialog.

Gonna redirect this to Paul - also because I'm about to go on PTO. :-)

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(pbz)
Severity: -- → S3
Priority: -- → P2
Has STR: --- → yes

The SubDialog keypress handler is closing the dialog:
https://searchfox.org/mozilla-central/rev/c2e3ac11be4837718c2604e58085fbc8252b69dd/toolkit/modules/SubDialog.jsm#609

I think we should move the esc key handling into the print dialog. The dialog elements of the other SubDialog consumers (preferences, prompts) already do this.

Ok, turns out the popup code cancels the keydown system event. But since the SubDialog code uses a normal event listener it still gets keydown and closes the dialog. Thanks for debugging this, Gijs!

Assignee: nobody → pbz
Status: NEW → ASSIGNED
Flags: needinfo?(pbz)
Component: Printing → Notifications and Alerts
Whiteboard: [print2020_v83] [old-ui-]
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5066eae18c2d SubDialog: Use system event listener for escape key. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/5066eae18c2d

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

status-firefox84: --- → ?
Flags: qe-verify+

This issue is verified fixed using FIrefox 85.0b4 (BuildId:20201220193140) and Firefox 86.0a1 (BuildId:20201221155804) on Windows 10 64bit, macOS 10.14 and Ubuntu 20.04

Status: RESOLVED → VERIFIED
status-firefox85: fixed → verified
status-firefox86: --- → verified
Flags: qe-verify+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: