Closed
Bug 1670175
Opened 4 years ago
Closed 4 years ago
Indicate that "elem" arguments of methods in MarionetteFrameParent are actually web element references
Categories
(Remote Protocol :: Marionette, task, P1)
Tracking
(Fission Milestone:M7, firefox84 fixed)
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [marionette-fission-mvp][simple])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
A lot of methods in MarionetteFrameParent take an elem argument that is actually a web element reference. We should indicate that, or rename it to webEl but pass it over to the child actor as element.
I would be more in favor of the second option given that this would give less confusion. Maja, what's your preferred solution?
Flags: needinfo?(mjzffr)
I prefer "rename it to webEl [in MarionetteFrameParent] but pass it over to the child actor as [elem]"
Flags: needinfo?(mjzffr)
|
||
Comment 2•4 years ago
|
||
Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7)
Fission Milestone: --- → M7
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
|
|
Assignee | |
Comment 3•4 years ago
|
||
Element references in the parent process are always WebElements.
As such rename element arguments of the parent actor methods,
but still pass them as elements to the child actor.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dafa26b89eda
[marionette] Use webEl as argument in MarionetteFrameParent. r=marionette-reviewers,maja_zf
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•