Closed
Bug 167038
Opened 22 years ago
Closed 22 years ago
[FIX]crash when going back to previous page (using keyboard: ALT + left arrow) [@ nsEventStateManager::HandleAccessKey ]
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla1.2alpha
People
(Reporter: per.angstrom, Assigned: bzbarsky)
References
()
Details
(4 keywords)
Crash Data
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
caillon
:
review+
jst
:
superreview+
roc
:
approval+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2a) Gecko/20020905
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2a) Gecko/20020905
If I open the URL and try to go back to the previous page, using the keyboard:
ALT + left arrow), Mozilla will crash. It doesn't seem to happen if I use the
back button.
Reproducible: Always
Steps to Reproduce:
1. Open the URL.
2. Press ALT + left arrow.
Actual Results:
Mozilla will crash.
Expected Results:
The previous page in the session history should be displayed.
I have only seen the problem on this specific URL.
First seen in build 20020904 for Linux. Also seen in build 20020904 for Windows.
No problem in Netscape 7 for Linux.
No error message on console.
Regarding Talkback, I think I need some education:
I have sent a couple of reports using the Quality Feedback Agent - is that the
same thing as Talkback, and how do I get a Talkback ID that I can report in this
forum?
Comment 1•22 years ago
|
||
Please post Talkback ID for these crash via
'mozilla/bin/components/talkback/talkback' on Linux or
'mozilla/bin/components/talkback.exe' on Windows.
Keywords: crash,
stackwanted
Reporter | ||
Comment 2•22 years ago
|
||
The Linux crash has ID TB10468672E.
The Windows crash has ID TB10468815Q.
Comment 3•22 years ago
|
||
Confirmed 2002090415 on WinNT4:
TB10470151G
TB10470241E
Comment 4•22 years ago
|
||
Confirming on Windows XP, build 2002090604.
Reporter | ||
Updated•22 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 5•22 years ago
|
||
Stacktrace from cvs trunk on Linux. Pressed ALT and left arrow on the page.
Comment 6•22 years ago
|
||
Seems to be a regression as I don't crash with Linux build 20020904.
Assignee: radha → joki
Component: History: Session → Event Handling
Keywords: stackwanted → regression
QA Contact: claudius → rakeshmishra
Summary: crash when going back to previous page (using keyboard: ALT + left arrow) → crash when going back to previous page (using keyboard: ALT + left arrow) [@ nsEventStateManager::HandleAccessKey ]
Comment 7•22 years ago
|
||
Possible checkins: bug 141295.
CC'ing people who produced the patch.
Comment 8•22 years ago
|
||
fix for bug 141295 was checked in on Sep 5th and, per comment 3, build 20020904
crashes.
Culprit checkin rather seems to be bug 129808.
CC'ing more people (sorry for the spam), leaving bryner as he gave r= to above
fix for bug 141295.
Comment 9•22 years ago
|
||
Adding testcase and topcrash+ keywords since people have been able to reproduce
this. Also making this a zt4newcrash bug since we know it is a regression
(according to Talkback data, this crash was introduced with 9/3 MozillaTrunk
builds).
Comment 10•22 years ago
|
||
*** Bug 167192 has been marked as a duplicate of this bug. ***
Comment 11•22 years ago
|
||
Duped bug 167192 has a recent stack trace and user comments if anyone needs to
take a look.
Assignee | ||
Comment 13•22 years ago
|
||
Add null check and some assertions.
Comment 14•22 years ago
|
||
Comment on attachment 98236 [details] [diff] [review]
fix
sr=jst
Attachment #98236 -
Flags: superreview+
Assignee | ||
Comment 15•22 years ago
|
||
taking
Assignee: joki → bzbarsky
Priority: -- → P1
Summary: crash when going back to previous page (using keyboard: ALT + left arrow) [@ nsEventStateManager::HandleAccessKey ] → [FIX]crash when going back to previous page (using keyboard: ALT + left arrow) [@ nsEventStateManager::HandleAccessKey ]
Target Milestone: --- → mozilla1.2alpha
Comment 16•22 years ago
|
||
Comment on attachment 98236 [details] [diff] [review]
fix
>Index: content/events/src/nsEventStateManager.cpp
>===================================================================
>
>+ // Docshells need not have a presshell (eg. display:none
>+ // iframes, docshells in transition between documents, etc).
>+ if (!subPS) {
>+ // Just move on to the next child
"If this is the case, just ..."
>+ continue;
>+ }
>+
>@@ -1037,12 +1045,14 @@
> nsCOMPtr<nsIPresShell> parentPS;
> nsCOMPtr<nsIPresContext> parentPC;
> nsCOMPtr<nsIEventStateManager> parentESM;
>
> parentDS->GetPresShell(getter_AddRefs(parentPS));
>+ NS_ASSERTION(parentPS, "Out presshell exists but the parent's does not?");
s/Out/Our/
r=caillon
Attachment #98236 -
Flags: review+
Comment 17•22 years ago
|
||
Comment on attachment 98236 [details] [diff] [review]
fix
One more nit: Two of your assertions use "PresShell" and one uses "presshell".
Pick one :-)
Comment on attachment 98236 [details] [diff] [review]
fix
a=roc+moz for trunk
Attachment #98236 -
Flags: approval+
Assignee | ||
Comment 19•22 years ago
|
||
fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 20•22 years ago
|
||
Confirming. WFM in build 20020906-22 on Linux.
Updated•22 years ago
|
QA Contact: rakeshmishra → trix
Updated•14 years ago
|
Crash Signature: [@ nsEventStateManager::HandleAccessKey ]
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•