Closed
Bug 16706
Opened 25 years ago
Closed 25 years ago
[DOGFOOD] [BLOCKER] HTML that is inserted into the editor with InsertAsSource() dissapears after first keystroke
Categories
(Core :: DOM: Editor, defect, P3)
Tracking
()
VERIFIED
FIXED
M11
People
(Reporter: rhp, Assigned: akkzilla)
References
Details
(Whiteboard: [PDT+])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
For mail/news, we use the InsertAsSource() calls to insert the HTML signature
for a new HTML message compose window. After this is done, everything appears
correct, but when you type the first keystroke, the contents that you inserted
vanish.
Assignee | ||
Updated•25 years ago
|
Assignee | ||
Comment 1•25 years ago
|
||
Accepting and would like to fix for M11, but right now I can't get signature
insertion to work for me at all due to bug 16708; marking a dependency on that
bug.
Reporter | ||
Updated•25 years ago
|
Summary: HTML that is inserted into the editor with InsertAsSource() dissapears after first keystroke → [BLOCKER] HTML that is inserted into the editor with InsertAsSource() dissapears after first keystroke
Reporter | ||
Updated•25 years ago
|
Summary: [BLOCKER] HTML that is inserted into the editor with InsertAsSource() dissapears after first keystroke → [DOGFOOD] [BLOCKER] HTML that is inserted into the editor with InsertAsSource() dissapears after first keystroke
Assignee | ||
Comment 2•25 years ago
|
||
Alec helped me get signatures working. The problem here is that we start with
an empty document containing only the editor bogus node; when the html gets
inserted, it gets inserted *inside* the bogus node, so anything that's typed
subsequently causes it all to disappear.
Cc'ing Joe, with whom I'll probably have to work to figure out how the bogus
node works and how to work around it for InsertHTML.
Assignee | ||
Comment 3•25 years ago
|
||
Assignee | ||
Comment 4•25 years ago
|
||
I've attached a patch which solves the problem. I'm not sure it's the best
permanent solution -- it has InsertHTML calling into the rules code only in the
case where the document is empty, and calling in with kInsertElement even though
it's about to delete something before it does the insert. But it does cure the
problem and makes both signatures and quoting work correctly with Rich's mail
patches.
It certainly doesn't make things any worse; if someone will review this, I can
go ahead and check it in, and hopefully Joe can advise on whether this is the
right thing to do in the long run. Oh, ignore the printf in the patch -- I
noticed and removed that right after attaching the patch, and it didn't seem
worth attaching another patch just for that.
Reporter | ||
Comment 5•25 years ago
|
||
For what it's worth, the patch looks fine to me. But I'm not very familiar with
that code.
- rhp
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•25 years ago
|
||
Checked in the fix as approved by Joe (a slightly different one than the one
attached here).
Reporter | ||
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 7•25 years ago
|
||
Yes, this is working fine now. Thanks!
- rhp
You need to log in
before you can comment on or make changes to this bug.
Description
•