Closed Bug 1670788 Opened 4 years ago Closed 4 years ago

No-op `mach vendor python` makes a lot of changes

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox-esr78 fixed, firefox81 unaffected, firefox82 unaffected, firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox-esr78 --- fixed
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 --- fixed

People

(Reporter: rstewart, Assigned: rstewart)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This wasn't an issue before bug 1654457.

The large majority of the changes are file deletions, but there are some renames, additions, and modifications as well.

STR:

  1. Apply the patch from bug 1670784 to fix mach vendor python.

  2. mach vendor python (no need to make any changes to requirements.in)

  3. git/hg status:

ricky@itsricky:~/src/mozilla-unified$ git status 
On branch scratch
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	new file:   third_party/python/virtualenv/AUTHORS.txt
	renamed:    third_party/python/virtualenv/virtualenv-20.0.31.dist-info/LICENSE -> third_party/python/virtualenv/LICENSE.txt
	new file:   third_party/python/virtualenv/MANIFEST.in
	new file:   third_party/python/virtualenv/PKG-INFO
	new file:   third_party/python/virtualenv/README.rst
	deleted:    third_party/python/virtualenv/README_MOZILLA
	deleted:    third_party/python/virtualenv/__main__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/appdirs-1.4.4-py2.py3-none-any/appdirs-1.4.4.dist-info/LICENSE.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/appdirs-1.4.4-py2.py3-none-any/appdirs-1.4.4.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/appdirs-1.4.4-py2.py3-none-any/appdirs-1.4.4.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/appdirs-1.4.4-py2.py3-none-any/appdirs-1.4.4.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/appdirs-1.4.4-py2.py3-none-any/appdirs-1.4.4.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/appdirs-1.4.4-py2.py3-none-any/appdirs.py
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/backports/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/backports/configparser/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/backports/configparser/helpers.py
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/configparser-4.0.2.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/configparser-4.0.2.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/configparser-4.0.2.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/configparser-4.0.2.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/configparser-4.0.2.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/configparser-4.0.2-py2.py3-none-any/configparser.py
	deleted:    third_party/python/virtualenv/__virtualenv__/contextlib2-0.6.0.post1-py2.py3-none-any/contextlib2-0.6.0.post1.dist-info/LICENSE.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/contextlib2-0.6.0.post1-py2.py3-none-any/contextlib2-0.6.0.post1.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/contextlib2-0.6.0.post1-py2.py3-none-any/contextlib2-0.6.0.post1.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/contextlib2-0.6.0.post1-py2.py3-none-any/contextlib2-0.6.0.post1.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/contextlib2-0.6.0.post1-py2.py3-none-any/contextlib2-0.6.0.post1.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/contextlib2-0.6.0.post1-py2.py3-none-any/contextlib2.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib-0.3.1.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib-0.3.1.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib-0.3.1.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/_backport/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/_backport/misc.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/_backport/shutil.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/_backport/sysconfig.cfg
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/_backport/sysconfig.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/_backport/tarfile.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/compat.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/database.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/index.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/locators.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/manifest.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/markers.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/metadata.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/resources.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/scripts.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/t32.exe
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/t64.exe
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/util.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/version.py
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/w32.exe
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/w64.exe
	deleted:    third_party/python/virtualenv/__virtualenv__/distlib-0.3.1-py2.py3-none-any/distlib/wheel.py
	deleted:    third_party/python/virtualenv/__virtualenv__/filelock-3.0.12-py3-none-any/filelock-3.0.12.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/filelock-3.0.12-py3-none-any/filelock-3.0.12.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/filelock-3.0.12-py3-none-any/filelock-3.0.12.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/filelock-3.0.12-py3-none-any/filelock-3.0.12.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/filelock-3.0.12-py3-none-any/filelock-3.0.12.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/filelock-3.0.12-py3-none-any/filelock.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.1.3-py2.py3-none-any/importlib_metadata-1.1.3.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.1.3-py2.py3-none-any/importlib_metadata-1.1.3.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.1.3-py2.py3-none-any/importlib_metadata-1.1.3.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.1.3-py2.py3-none-any/importlib_metadata-1.1.3.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.1.3-py2.py3-none-any/importlib_metadata-1.1.3.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.1.3-py2.py3-none-any/importlib_metadata/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.1.3-py2.py3-none-any/importlib_metadata/_compat.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.7.0-py2.py3-none-any/importlib_metadata-1.7.0.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.7.0-py2.py3-none-any/importlib_metadata-1.7.0.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.7.0-py2.py3-none-any/importlib_metadata-1.7.0.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.7.0-py2.py3-none-any/importlib_metadata-1.7.0.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.7.0-py2.py3-none-any/importlib_metadata-1.7.0.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.7.0-py2.py3-none-any/importlib_metadata/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_metadata-1.7.0-py2.py3-none-any/importlib_metadata/_compat.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources-1.0.2.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources-1.0.2.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources-1.0.2.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources-1.0.2.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources-1.0.2.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources/_compat.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources/_py2.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources/_py3.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources/abc.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-1.0.2-py2.py3-none-any/importlib_resources/version.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources-3.0.0.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources-3.0.0.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources-3.0.0.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources-3.0.0.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources-3.0.0.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/_common.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/_compat.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/_py2.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/_py3.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/abc.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/py.typed
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/readers.py
	deleted:    third_party/python/virtualenv/__virtualenv__/importlib_resources-3.0.0-py2.py3-none-any/importlib_resources/trees.py
	deleted:    third_party/python/virtualenv/__virtualenv__/pathlib2-2.3.5-py2.py3-none-any/pathlib2-2.3.5.dist-info/DESCRIPTION.rst
	deleted:    third_party/python/virtualenv/__virtualenv__/pathlib2-2.3.5-py2.py3-none-any/pathlib2-2.3.5.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/pathlib2-2.3.5-py2.py3-none-any/pathlib2-2.3.5.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/pathlib2-2.3.5-py2.py3-none-any/pathlib2-2.3.5.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/pathlib2-2.3.5-py2.py3-none-any/pathlib2-2.3.5.dist-info/metadata.json
	deleted:    third_party/python/virtualenv/__virtualenv__/pathlib2-2.3.5-py2.py3-none-any/pathlib2-2.3.5.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/pathlib2-2.3.5-py2.py3-none-any/pathlib2/__init__.py
	deleted:    third_party/python/virtualenv/__virtualenv__/scandir-1.10.0-cp38-cp38-macosx_10_15_x86_64/scandir-1.10.0.dist-info/LICENSE.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/scandir-1.10.0-cp38-cp38-macosx_10_15_x86_64/scandir-1.10.0.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/scandir-1.10.0-cp38-cp38-macosx_10_15_x86_64/scandir-1.10.0.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/scandir-1.10.0-cp38-cp38-macosx_10_15_x86_64/scandir-1.10.0.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/scandir-1.10.0-cp38-cp38-macosx_10_15_x86_64/scandir-1.10.0.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/scandir-1.10.0-cp38-cp38-macosx_10_15_x86_64/scandir.py
	deleted:    third_party/python/virtualenv/__virtualenv__/six-1.15.0-py2.py3-none-any/six-1.15.0.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/six-1.15.0-py2.py3-none-any/six-1.15.0.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/six-1.15.0-py2.py3-none-any/six-1.15.0.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/six-1.15.0-py2.py3-none-any/six-1.15.0.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/six-1.15.0-py2.py3-none-any/six-1.15.0.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/six-1.15.0-py2.py3-none-any/six.py
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.1-py3-none-any/typing-3.7.4.1.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.1-py3-none-any/typing-3.7.4.1.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.1-py3-none-any/typing-3.7.4.1.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.1-py3-none-any/typing-3.7.4.1.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.1-py3-none-any/typing-3.7.4.1.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.1-py3-none-any/typing.py
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.3-py2-none-any/typing-3.7.4.3.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.3-py2-none-any/typing-3.7.4.3.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.3-py2-none-any/typing-3.7.4.3.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.3-py2-none-any/typing-3.7.4.3.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.3-py2-none-any/typing-3.7.4.3.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/typing-3.7.4.3-py2-none-any/typing.py
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-1.2.0-py2.py3-none-any/zipp-1.2.0.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-1.2.0-py2.py3-none-any/zipp-1.2.0.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-1.2.0-py2.py3-none-any/zipp-1.2.0.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-1.2.0-py2.py3-none-any/zipp-1.2.0.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-1.2.0-py2.py3-none-any/zipp-1.2.0.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-1.2.0-py2.py3-none-any/zipp.py
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-3.1.0-py3-none-any/zipp-3.1.0.dist-info/LICENSE
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-3.1.0-py3-none-any/zipp-3.1.0.dist-info/METADATA
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-3.1.0-py3-none-any/zipp-3.1.0.dist-info/RECORD
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-3.1.0-py3-none-any/zipp-3.1.0.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-3.1.0-py3-none-any/zipp-3.1.0.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/__virtualenv__/zipp-3.1.0-py3-none-any/zipp.py
	deleted:    third_party/python/virtualenv/distributions.json
	deleted:    third_party/python/virtualenv/modules.json
	new file:   third_party/python/virtualenv/pyproject.toml
	new file:   third_party/python/virtualenv/setup.cfg
	new file:   third_party/python/virtualenv/setup.py
	new file:   third_party/python/virtualenv/tasks/make_zipapp.py
	new file:   third_party/python/virtualenv/tasks/release.py
	new file:   third_party/python/virtualenv/tasks/update_embedded.py
	new file:   third_party/python/virtualenv/tasks/upgrade_wheels.py
	new file:   third_party/python/virtualenv/tox.ini
	deleted:    third_party/python/virtualenv/virtualenv-20.0.31.dist-info/METADATA
	deleted:    third_party/python/virtualenv/virtualenv-20.0.31.dist-info/RECORD
	deleted:    third_party/python/virtualenv/virtualenv-20.0.31.dist-info/WHEEL
	deleted:    third_party/python/virtualenv/virtualenv-20.0.31.dist-info/entry_points.txt
	deleted:    third_party/python/virtualenv/virtualenv-20.0.31.dist-info/top_level.txt
	deleted:    third_party/python/virtualenv/virtualenv-20.0.31.dist-info/zip-safe
	modified:   third_party/python/virtualenv/virtualenv.py
	deleted:    third_party/python/virtualenv/virtualenv/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/__main__.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/activator.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/bash/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/batch/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/batch/pydoc.bat
	deleted:    third_party/python/virtualenv/virtualenv/activation/cshell/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/fish/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/powershell/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/python/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/python/activate_this.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/via_template.py
	deleted:    third_party/python/virtualenv/virtualenv/activation/xonsh/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/app_data/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/app_data/base.py
	deleted:    third_party/python/virtualenv/virtualenv/app_data/na.py
	deleted:    third_party/python/virtualenv/virtualenv/app_data/via_disk_folder.py
	deleted:    third_party/python/virtualenv/virtualenv/app_data/via_tempdir.py
	deleted:    third_party/python/virtualenv/virtualenv/config/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/config/cli/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/config/cli/parser.py
	deleted:    third_party/python/virtualenv/virtualenv/config/convert.py
	deleted:    third_party/python/virtualenv/virtualenv/config/env_var.py
	deleted:    third_party/python/virtualenv/virtualenv/config/ini.py
	deleted:    third_party/python/virtualenv/virtualenv/create/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/create/creator.py
	deleted:    third_party/python/virtualenv/virtualenv/create/debug.py
	deleted:    third_party/python/virtualenv/virtualenv/create/describe.py
	deleted:    third_party/python/virtualenv/virtualenv/create/pyenv_cfg.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/_virtualenv.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/api.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/builtin_way.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/cpython/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/cpython/common.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/cpython/cpython2.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/cpython/cpython3.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/cpython/mac_os.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/pypy/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/pypy/common.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/pypy/pypy2.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/pypy/pypy3.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/python2/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/python2/python2.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/python2/site.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/ref.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/via_global_self_do.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/store.py
	deleted:    third_party/python/virtualenv/virtualenv/create/via_global_ref/venv.py
	deleted:    third_party/python/virtualenv/virtualenv/discovery/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/discovery/builtin.py
	deleted:    third_party/python/virtualenv/virtualenv/discovery/cached_py_info.py
	deleted:    third_party/python/virtualenv/virtualenv/discovery/discover.py
	deleted:    third_party/python/virtualenv/virtualenv/discovery/py_info.py
	deleted:    third_party/python/virtualenv/virtualenv/discovery/py_spec.py
	deleted:    third_party/python/virtualenv/virtualenv/discovery/windows/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/discovery/windows/pep514.py
	deleted:    third_party/python/virtualenv/virtualenv/info.py
	deleted:    third_party/python/virtualenv/virtualenv/report.py
	deleted:    third_party/python/virtualenv/virtualenv/run/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/run/plugin/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/run/plugin/activators.py
	deleted:    third_party/python/virtualenv/virtualenv/run/plugin/base.py
	deleted:    third_party/python/virtualenv/virtualenv/run/plugin/creators.py
	deleted:    third_party/python/virtualenv/virtualenv/run/plugin/discovery.py
	deleted:    third_party/python/virtualenv/virtualenv/run/plugin/seeders.py
	deleted:    third_party/python/virtualenv/virtualenv/run/session.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/base_embed.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/pip_invoke.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/via_app_data/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/via_app_data/pip_install/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/via_app_data/pip_install/base.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/via_app_data/pip_install/copy.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/via_app_data/pip_install/symlink.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/embed/via_app_data/via_app_data.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/seeder.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/acquire.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/bundle.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/embed/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/embed/pip-20.2.2-py2.py3-none-any.whl
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/embed/setuptools-44.1.1-py2.py3-none-any.whl
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/embed/setuptools-49.6.0-py3-none-any.whl
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/embed/wheel-0.35.1-py2.py3-none-any.whl
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/periodic_update.py
	deleted:    third_party/python/virtualenv/virtualenv/seed/wheels/util.py
	deleted:    third_party/python/virtualenv/virtualenv/util/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/util/error.py
	deleted:    third_party/python/virtualenv/virtualenv/util/lock.py
	deleted:    third_party/python/virtualenv/virtualenv/util/path/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/util/path/_pathlib/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/util/path/_pathlib/via_os_path.py
	deleted:    third_party/python/virtualenv/virtualenv/util/path/_permission.py
	deleted:    third_party/python/virtualenv/virtualenv/util/path/_sync.py
	deleted:    third_party/python/virtualenv/virtualenv/util/six.py
	deleted:    third_party/python/virtualenv/virtualenv/util/subprocess/__init__.py
	deleted:    third_party/python/virtualenv/virtualenv/util/subprocess/_win_subprocess.py
	deleted:    third_party/python/virtualenv/virtualenv/util/zipapp.py
	deleted:    third_party/python/virtualenv/virtualenv/version.py
	renamed:    third_party/python/virtualenv/virtualenv/activation/batch/activate.bat -> third_party/python/virtualenv/virtualenv_embedded/activate.bat
	renamed:    third_party/python/virtualenv/virtualenv/activation/cshell/activate.csh -> third_party/python/virtualenv/virtualenv_embedded/activate.csh
	renamed:    third_party/python/virtualenv/virtualenv/activation/fish/activate.fish -> third_party/python/virtualenv/virtualenv_embedded/activate.fish
	renamed:    third_party/python/virtualenv/virtualenv/activation/powershell/activate.ps1 -> third_party/python/virtualenv/virtualenv_embedded/activate.ps1
	renamed:    third_party/python/virtualenv/virtualenv/activation/bash/activate.sh -> third_party/python/virtualenv/virtualenv_embedded/activate.sh
	renamed:    third_party/python/virtualenv/virtualenv/activation/xonsh/activate.xsh -> third_party/python/virtualenv/virtualenv_embedded/activate.xsh
	new file:   third_party/python/virtualenv/virtualenv_embedded/activate_this.py
	renamed:    third_party/python/virtualenv/virtualenv/activation/batch/deactivate.bat -> third_party/python/virtualenv/virtualenv_embedded/deactivate.bat
	new file:   third_party/python/virtualenv/virtualenv_embedded/distutils-init.py
	new file:   third_party/python/virtualenv/virtualenv_embedded/distutils.cfg
	new file:   third_party/python/virtualenv/virtualenv_embedded/python-config
	new file:   third_party/python/virtualenv/virtualenv_embedded/site.py
	renamed:    third_party/python/virtualenv/virtualenv/create/via_global_ref/__init__.py -> third_party/python/virtualenv/virtualenv_support/__init__.py
	renamed:    third_party/python/virtualenv/virtualenv/seed/wheels/embed/pip-19.1.1-py2.py3-none-any.whl -> third_party/python/virtualenv/virtualenv_support/pip-19.1.1-py2.py3-none-any.whl
	new file:   third_party/python/virtualenv/virtualenv_support/pip-19.3.1-py2.py3-none-any.whl
	renamed:    third_party/python/virtualenv/virtualenv/seed/wheels/embed/setuptools-43.0.0-py2.py3-none-any.whl -> third_party/python/virtualenv/virtualenv_support/setuptools-41.6.0-py2.py3-none-any.whl
	renamed:    third_party/python/virtualenv/virtualenv/seed/wheels/embed/wheel-0.33.6-py2.py3-none-any.whl -> third_party/python/virtualenv/virtualenv_support/wheel-0.33.6-py2.py3-none-any.whl

Looks like third_party/python/requirements.in wasn't updated, so it's vendoring the old version of the package.

I tried updating third_party/python/requirements.in, but that made a similar amount of changes and results in all builds breaking. third_party/python/virtualenv/{README_MOZILLA,virtualenv.py} also get deleted which is very unfortunate.

Mike, what happened here? Did you not use mach vendor python to vendor this version of virtualenv? Do you want to remove virtualenv from third_party/python/requirements.in so mach vendor python stops handling it?

Flags: needinfo?(mh+mozilla)

Ah, the README actually addresses this:

It is not vendored via `mach vendor` because that would require a larger wrapper
script that handles the same things as the zipapp already does, picking the right
dependencies to add to the PYTHONPATH depending on the python version.

I'll remove it from requirements.in.

Flags: needinfo?(mh+mozilla)

This package isn't vendored via mach vendor any more (since bug 1654457), but its presence here means that mach vendor python tries to vendor it anyway.

Assignee: nobody → rstewart
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1654457

Pushed by rstewart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4e28d423a4f Remove `virtualenv` from `third_party/python/requirements.in` r=firefox-build-system-reviewers,glandium
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Comment on attachment 9181106 [details]
Bug 1670788 - Remove virtualenv from third_party/python/requirements.in

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Resolves issue where mach vendor python changes too many files.
    Note that I doubt mach vendor python is used on ESR.
  • User impact if declined: None
  • Fix Landed on Version: 83
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a build-only patch
  • String or UUID changes made by this patch:
Attachment #9181106 - Flags: approval-mozilla-esr78?
Attachment #9181106 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: