Closed Bug 1671061 Opened 4 years ago Closed 4 years ago

SWGL crash in RenderTextureHostSWGL::UpdatePlanes when using WebGL on Mac

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Platform:
x86_64
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox82 --- disabled
firefox83 --- disabled
firefox84 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(3 files)

Bug 1671061 - Refactor IOSurface creation code to use shared helpers. r?mstange
(deleted), text/x-phabricator-request
Details
Bug 1671061 - Set BGRA format on IOSurfaces. r?mstange
(deleted), text/x-phabricator-request
Details
Bug 1671061 - Pad IOSurface allocations for SWGL since it reads in chunks of 4 pixels. r?lsalzman
(deleted), text/x-phabricator-request
Details

This shouldn't have any behaviour changes, just removes some code duplication.

Previously we weren't setting any format on these surfaces (despite the inputs being BGRA), and GetFormat was hitting the default: case to return RGBA.

CGLTexImageIOSurface2D binds these with a format of GL_BGRA, but an internal format of GL_RGBA, which is why returning RGBA from GetFormat was sometimes useful.

We return a format of RGBA as an outparam when binding to a texture, so this changes the callers that really want the GL internal format to use that rather than GetFormat.

Depends on D93610

Attachment #9181698 - Attachment description: Bug 1671061 - Pad IOSurface allocations for SWGL since it reads in chunks of 4 bytes. r?lsalzman → Bug 1671061 - Pad IOSurface allocations for SWGL since it reads in chunks of 4 pixels. r?lsalzman
Crash Signature: [@ mozilla::wr::RenderTextureHostSWGL::UpdatePlanes(mozilla::wr::ImageRendering)]
status-firefox84: --- → disabled
Keywords: crash
OS: Unspecified → macOS
Hardware: Unspecified → x86_64
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3070cc80049 Refactor IOSurface creation code to use shared helpers. r=mstange https://hg.mozilla.org/integration/autoland/rev/e8faa0d10533 Set BGRA format on IOSurfaces. r=mstange https://hg.mozilla.org/integration/autoland/rev/08541f198a99 Pad IOSurface allocations for SWGL since it reads in chunks of 4 pixels. r=lsalzman

https://hg.mozilla.org/mozilla-central/rev/a3070cc80049
https://hg.mozilla.org/mozilla-central/rev/e8faa0d10533
https://hg.mozilla.org/mozilla-central/rev/08541f198a99

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

I knew this bug existed, but I filed bug 1671948 because these patches didn't appear to fix the crash (I should have included a better description). Here's a try run that includes these three patches (maybe they're out of date in my try push?), and also stands up a new talos task:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8b5384ac0e1990925cff26cc0845e45519caa4d&searchStr=macos%2Cwebgl

I'll leave it up to whoever investigates to decide whether to re-open this bug or re-open bug 1671948.

Blocks: sw-wr-stability
No longer blocks: sw-wr-correctness
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: