Build busted by bug 1669573 changes to date formatting
Categories
(Thunderbird :: Upstream Synchronization, defect)
Tracking
(thunderbird_esr78 unaffected, thunderbird82 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
| thunderbird82 | --- | unaffected |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: leave-open, regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1669573 renamed a bunch of enums that we have in our code. Porting that change is fine.
It also removed the kDateFormatWeekday option, which our code uses if the user sets a pref, and is presumably used by some users. (Setting the pref to this value displays mail that arrived in the last week as "Tue, 12:34 pm" rather than "16/10/2020, 12:34 pm" or whatever the default is in your locale.)
I'm going to change our code so that it compiles by removing the option to format with the day name, but we might want to reinstate it somehow.
|
Assignee | |
Comment 1•4 years ago
|
||
This kills the option to set mail.ui.display.dateformat.thisweek = 4.
|
||
Comment 2•4 years ago
|
||
Ah! I'm so sorry for not flagging you in that bug prior to landing.
We're going to clean up the DateTimeFormat class but we do want to bring actually more functionality, not less.
In particular, the aim is to restore ability for users to specify their own pattern overrides via prefs (so that users can set, for example ISO format).
If you have particular formats that you'd like us to support, please let me know and we'll get it.
|
|
Assignee | |
Comment 3•4 years ago
|
||
No problem Zibi, I could tell you're in the middle of things.
Landing now, keeping the bug open so I remember to keep an eye on it.
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/84ddce4d8035 Port bug 1669573 - Changes to date formatting enums. r=rjl
|
||
Comment 5•4 years ago
|
||
Not that I think there's much point with the mail.ui.display.dateformat 4 option, but what happens when someone had that set?
|
|
Assignee | |
Comment 6•4 years ago
|
||
If I understand the code correctly, it will just be ignored and the default will be used.
|
|
Assignee | |
Comment 7•4 years ago
|
||
Closing this in favour of the follow-up I just filed.
|
||
Updated•3 years ago
|
|
||
Comment 8•3 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #5)
Not that I think there's much point with the mail.ui.display.dateformat 4 option, but what happens when someone had that set?
Option 4 was very useful, for "recent" e-mail within the last seven days you could display the weekday instead of the date.
Description
•