Collect telemetry on page load and animation frame callback times
Categories
(Core :: Performance, enhancement)
Tracking
()
People
(Reporter: denispal, Assigned: denispal)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
(deleted),
text/plain
|
chutten
:
data-review+
|
Details |
FX_PAGE_LOAD_MS_2, and the navigation probes TIME_TO_LOAD_EVENT_START_MS, etc, will collect data for content that is not http/https. This includes opening a new tab, navigating to about:blank, any extension content, etc. FX_PAGE_LOAD_MS_2 will also stop timing when a user navigates off the page through switching tabs or clicking on a link.
There is a need for some metrics that measure page load time on http and https content only, comparing against both navigationStart and responseStart to see if some network noise can be eliminated from the measurement.
Additionally, we should consider measuring the time it takes for an animation frame callback so that it can be used to measure improvements but also identify any pathological cases where it is not performing well.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Comment 7•4 years ago
|
||
Comment on attachment 9182922 [details]
data-review-1671729.md
DATA COLLECTION REVIEW RESPONSE:
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes.
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.
If the request is for permanent data collection, is there someone who will monitor the data over time?
Yes, Denis Palmeiro is responsible.
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 2, Interaction.
Is the data collection request for default-on or default-off?
Default on for pre-release channels only.
Does the instrumentation include the addition of any new identifiers?
No.
Is the data collection covered by the existing Firefox privacy notice?
Yes.
Does there need to be a check-in in the future to determine whether to renew the data?
No. This collection is permanent.
Result: datareview+
Updated•4 years ago
|
Comment 9•4 years ago
|
||
bugherder |
Assignee | ||
Comment 10•4 years ago
|
||
Comment on attachment 9182397 [details]
Gather telemetry on page load and request animation frame callback time
Beta/Release Uplift Approval Request
- User impact if declined: Crash as in bug 1672503.
- Is this code covered by automated tests?: Unknown
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This patch fixes a crash in bug 1672503 that is also present in beta. Alongside, it also implements a few new probes we would like to monitor for a performance experiment once 83 enters release.
- String changes made/needed:
Comment 11•4 years ago
|
||
Comment on attachment 9182397 [details]
Gather telemetry on page load and request animation frame callback time
Approved for 83 beta 5, thanks.
Comment 12•4 years ago
|
||
bugherder uplift |
Description
•