Closed
Bug 1671871
Opened 4 years ago
Closed 4 years ago
[MIPS] Implements WasmBuiltinTruncateToInt32
Categories
(Core :: JavaScript: WebAssembly, defect, P3)
Tracking
()
RESOLVED
FIXED
84 Branch
People
(Reporter: zhaojiazhong-hf, Assigned: zhaojiazhong-hf)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
D89550 introduced some functions that were not implemented on mips platform, like lowerWasmBuiltinTruncateToInt32.
Now some tests failed due to these unimplemented functions.
|
Assignee | |
Comment 1•4 years ago
|
||
Port D89550 to mips platform.
|
||
Updated•4 years ago
|
Assignee: nobody → zhaojiazhong-hf
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67b1590895ee
[MIPS] Add tls dependency for truncate i32. r=lth
|
||
Updated•4 years ago
|
Severity: -- → S4
Priority: -- → P3
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
|
||
Comment 4•4 years ago
|
||
The patch landed in nightly and beta is affected.
:zhaojiazhong-hf, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
Flags: needinfo?(zhaojiazhong-hf)
|
|
Assignee | |
Comment 5•4 years ago
|
||
Comment on attachment 9182270 [details]
Bug 1671871 - [MIPS] Add tls dependency for truncate i32. r=lth
Beta/Release Uplift Approval Request
- User impact if declined: Spider Monkey and firefox may crash on mips platform.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It only affects mips platform, and the modified functions were going to crash before.
- String changes made/needed:
Flags: needinfo?(zhaojiazhong-hf)
Attachment #9182270 -
Flags: approval-mozilla-beta?
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9182270 [details]
Bug 1671871 - [MIPS] Add tls dependency for truncate i32. r=lth
Approved for 83 beta 5, thanks.
Attachment #9182270 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 7•4 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•