Closed
Bug 1671960
Opened 4 years ago
Closed 4 years ago
Add fast-path of AtomizeChars in ParserAtomEntry::toJSAtom
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
84 Branch
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: arai, Assigned: tcampbell)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
ParserAtoms has the same static strings as JSAtoms,
and ParserAtomEntry::toJSAtom
handles them separately before AtomizeChars
.
we don't have to lookup static string on JSAtom side.
Reporter | ||
Comment 1•4 years ago
|
||
Depends on D94097
Updated•4 years ago
|
Attachment #9182741 -
Attachment is obsolete: true
Assignee | ||
Updated•4 years ago
|
Assignee: arai.unmht → tcampbell
Summary: Skip static string lookup in AtomizeChars in ParserAtomEntry::toJSAtom → Add fast-path of AtomizeChars in ParserAtomEntry::toJSAtom
Assignee | ||
Comment 2•4 years ago
|
||
Since we use the same HashString for both types of atoms, we can save some
time while converting between them by reusing the HashNumber. This is
beneficial for Stencil-XDR where decoding times are quite fast and handling
atoms is a noticeable delay.
Assignee | ||
Comment 3•4 years ago
|
||
We discovered that the since JSAtom uses static-strings for more cases than ParserAtoms, we still need the static strings code. I am repurposing this bug to instead pass the HashNumber to the special AtomizeChars call.
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aaedffcfb8a1
Forward HashNumber from ParserAtom to JSAtom. r=arai
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•