Closed
Bug 1672251
Opened 4 years ago
Closed 4 years ago
Profiling tests that trigger private browsing should be possible
Categories
(Core :: Gecko Profiler, enhancement, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We lock the profiler when private browsing windows exist to avoid leaking data, but I don't think that concern applies when running tests in our automation.
I've seen this test that verifies that the profiler is locked in private browsing: https://searchfox.org/mozilla-central/rev/61728de8273c04fe2417c475fc0637e8b79210d7/devtools/server/tests/browser/browser_perf-03.js
It's possible to change the behavior and still have that test pass. I even managed to capture a profile of it: https://share.firefox.dev/31qED1i
I'm not sure if there are other tests that might be tricky to workaround.
|
Assignee | |
Comment 1•4 years ago
|
||
Severity: -- → N/A
Priority: -- → P3
|
||
Updated•4 years ago
|
Attachment #9182700 -
Attachment description: Bug 1672251 - Allow profiling tests that trigger private browsing, r=gerald. → Bug 1672251 - Allow capturing profiles of tests that trigger private browsing, r=gerald.
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0189678a564b
Allow capturing profiles of tests that trigger private browsing, r=gerald.
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•