Change the updater's downloadUpdate functions to return success rather than update state
Categories
(Toolkit :: Application Update, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: bytesized, Assigned: bytesized)
References
Details
Attachments
(2 files)
Currently, AUS.downloadUpdate and Downloader.downloadUpdate return the updater state. However, this isn't fully compatible with the multiple updates per Firefox session feature that I'm working on (Bug 353804). If the current state is STATE_PENDING, it will still be STATE_PENDING after downloadUpdate is called, whether it succeeds or fails. Therefore, I think it makes more sense to just return a boolean success value.
The only callers that use the return value just compare it to STATE_NONE to check for failure, so this mechanism will serve their purposes just fine.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
While making other changes, I took a second look at some code I wrote in Bug 1668096, and found a few little mistakes. This patch fixes them up.
Depends on D94191
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6172a10e7252
https://hg.mozilla.org/mozilla-central/rev/ddedbce9ad9f
Description
•