Closed
Bug 1672306
Opened 4 years ago
Closed 4 years ago
Don't enable rust "global" LTO when cross LTO is enabled
Categories
(Firefox Build System :: General, task)
Firefox Build System
General
Tracking
(firefox84 fixed)
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Keywords: perf-alert)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
This avoids a sort of duplication of work between both, because the
linker will eventually LTO-compile everything, so we technically don't
really need the extra step of the rust compiler doing an intermediate
LTO on the static libraries it produces.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/6dd2f083cad4
Don't enable rust "global" LTO when cross LTO is enabled. r=firefox-build-system-reviewers,dmajor
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
|
||
Comment 4•4 years ago
|
||
== Change summary for alert #27374 (as of Mon, 26 Oct 2020 14:38:53 GMT) ==
Improvements:
| Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|---|
| 20% | build times | windows2012-64-shippable | nightly taskcluster-m5n.4xlarge | 2,501.07 -> 1,996.01 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27374
Keywords: perf-alert
You need to log in
before you can comment on or make changes to this bug.
Description
•