Remove browser.toolbars.bookmarks.2h2020 pref and the dead code when the pref is always true
Categories
(Firefox :: Bookmarks & History, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: jaws, Assigned: mkohler)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files)
|
Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r?mak
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1665353 tracks some changes we are making to bookmarks in Firefox. Part of that work introduced a pref named "browser.toolbars.bookmarks.2h2020" which is used for experimentation and gating of the feature work.
After we have concluded experimentation, we should remove the preference and the then-dead code that will result from the decision of which behavior to use going forward.
|
||
Comment 1•4 years ago
|
||
I would love to take this issue, although I may need some guidance along the way as it will be my first issue related to firefox desktop.
|
Reporter | |
Comment 2•4 years ago
|
||
I don't know if we are ready to remove this pref yet. We are still gathering data to determine the effects of this change. We should have those results in a couple weeks.
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 3•3 years ago
|
||
Hey jaws,
browser.toolbars.bookmarks.2h2020 has been set to true for a number of months now... can we presume this is where we want to keep it, and can remove the pref and its false branches?
|
|
Reporter | |
Comment 4•3 years ago
|
||
(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)
Hey jaws,
browser.toolbars.bookmarks.2h2020 has been set to
truefor a number of months now... can we presume this is where we want to keep it, and can remove the pref and itsfalsebranches?
Yes, it should be safe to remove the pref now.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 5•3 years ago
|
||
|
|
Assignee | |
Comment 6•3 years ago
|
||
Depends on D127588
|
|
Assignee | |
Comment 7•3 years ago
|
||
Depends on D127589
|
|
Assignee | |
Comment 8•3 years ago
|
||
Depends on D127590
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e412f90c3aeb
https://hg.mozilla.org/mozilla-central/rev/ec76ea1a53cb
https://hg.mozilla.org/mozilla-central/rev/6981831be52e
https://hg.mozilla.org/mozilla-central/rev/ab41490c55e0
Description
•