Closed Bug 1672577 Opened 4 years ago Closed 3 years ago

Remove or update probes expiring in Firefox 85: NUMBER_OF_PROFILES

Categories

(Toolkit :: Startup and Profile System, task)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: telemetry-probes, Assigned: youhai.li)

References

Details

(Whiteboard: [probe-expiry-alert])

Attachments

(2 files)

The following Firefox probes will expire in the next major Firefox nightly release: version 85 [1].

NUMBER_OF_PROFILES

What to do about this:

  1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
  2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #fx-metrics Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Flags: needinfo?(dtownsend)

I wonder if we can/should remove this in favour of the new telemetry from bug 1647422

Flags: needinfo?(ksteuber)

Probably Romain's call.

Flags: needinfo?(dtownsend) → needinfo?(rtestard)

While I'm happy to answer questions about the two probes and the differences between them, this really seems like more of a question about whether they are both useful to us. Since I don't personally use either probe, I'm not sure that I'm in a good position to answer the question. Hopefully Romain can provide some answers here.

Flags: needinfo?(ksteuber)

This patch Remove probes expiring in Firefox 85: NUMBER_OF_PROFILES.
Changes in this patch includes:

toolkit/components/telemetry/Histograms.json 
Line 14405
Deleted field NUMBER_OF_PROFILES

toolkit/components/telemetry/histogram-allowlists.json
Line 1169
Deleted field NUMBER_OF_PROFILES

toolkit/xre/nsXREDirProvider.cpp
Line 1006
Deleted telemetry trigger for toggling NUMBER_OF_PROFILES

Browser Chrome Test passed with no failure. However, after "SUITE END", the test encountered unexpected failure:
0:13.51 TEST-UNEXPECTED-FAIL | No tests collected (Not in PYTHON_UNITTEST_MANIFESTS?)

with log messages indicating missing test files under directory toolkit/components/telemetry/tests/marionette/tests.

Flags: needinfo?(chutten)

Awaiting Romain's feedback.

Flags: needinfo?(chutten)

I don't personally see a use for this old probe, OK to remove it.

Flags: needinfo?(rtestard)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

I've uploaded Youhai Li's patch using phabricator, with their name as author.

Assignee: gijskruitbosch+bugs → youhai.li
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/95cf6de34f88 Removed expired probe NUMBER_OF_PROFILES, r=jaws
Backout by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69dead3de477 Backed out changeset 95cf6de34f88 for Browser-chrome in toolkit/components/backgroundtasks/tests/browser/browser_xpcom_graph_wait.js. CLOSED TREE
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1848564c277d Removed expired probe NUMBER_OF_PROFILES, r=jaws,nalexander
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: