Remove or update probes expiring in Firefox 85: NUMBER_OF_PROFILES
Categories
(Toolkit :: Startup and Profile System, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: telemetry-probes, Assigned: youhai.li)
References
Details
(Whiteboard: [probe-expiry-alert])
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/x-phabricator-request
|
Details |
The following Firefox probes will expire in the next major Firefox nightly release: version 85 [1].
NUMBER_OF_PROFILES
What to do about this:
- If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
- If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].
If you have any problems, please ask for help on the #fx-metrics Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.
Your Friendly, Neighborhood Telemetry Team
[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md
This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.
Comment 1•4 years ago
|
||
I wonder if we can/should remove this in favour of the new telemetry from bug 1647422
Comment 3•4 years ago
|
||
While I'm happy to answer questions about the two probes and the differences between them, this really seems like more of a question about whether they are both useful to us. Since I don't personally use either probe, I'm not sure that I'm in a good position to answer the question. Hopefully Romain can provide some answers here.
This patch Remove probes expiring in Firefox 85: NUMBER_OF_PROFILES.
Changes in this patch includes:
toolkit/components/telemetry/Histograms.json
Line 14405
Deleted field NUMBER_OF_PROFILES
toolkit/components/telemetry/histogram-allowlists.json
Line 1169
Deleted field NUMBER_OF_PROFILES
toolkit/xre/nsXREDirProvider.cpp
Line 1006
Deleted telemetry trigger for toggling NUMBER_OF_PROFILES
Browser Chrome Test passed with no failure. However, after "SUITE END", the test encountered unexpected failure:
0:13.51 TEST-UNEXPECTED-FAIL | No tests collected (Not in PYTHON_UNITTEST_MANIFESTS?)
with log messages indicating missing test files under directory toolkit/components/telemetry/tests/marionette/tests.
File changes for the above patch includes:
https://searchfox.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.cpp#1006
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#14405
I would like to work on this patch!
Comment 7•4 years ago
|
||
I don't personally see a use for this old probe, OK to remove it.
Comment 8•3 years ago
|
||
Updated•3 years ago
|
Comment 9•3 years ago
|
||
I've uploaded Youhai Li's patch using phabricator, with their name as author.
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Comment 11•3 years ago
|
||
Comment 12•3 years ago
|
||
Looks like that test needs updating. I'll look tomorrow.
Comment 13•3 years ago
|
||
Updated•3 years ago
|
Comment 14•3 years ago
|
||
Comment 15•3 years ago
|
||
bugherder |
Description
•