Closed Bug 1672798 Opened 4 years ago Closed 4 years ago

Port bug 1654103: Reformat comm-central Python code with black; run black mozlint in CI

Categories

(Thunderbird :: Build Config, task)

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
84 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(5 files)

This is something that should help considerably with readability of our Python code. Running the formatting is only part of of it, we need to make sure that CI runs the checks on every push that changes the affected files as well or it's useless.
See taskcluster/ci/source-test/mozlint.yml:py-black for the CI portion. It should port fairly easily.

Depends on: 1654103
Assignee: nobody → rob
Status: NEW → ASSIGNED

Bringing some sanity to our Python scripts.

Depends on D95399

Bringing some sanity to our Python scripts.

Depends on D95400

These will not be covered by CI for the moment because the global exclude does
not permit reincluding certain files. That deficiency in coverage can be addressed
in a follow-up bug.

Depends on D95402

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/e2ab56cfb900
Add black formatting mozlint check to run in CI. r=justdave
https://hg.mozilla.org/comm-central/rev/340ec9b2ed5d
Run black formatting on all python files. r=mkmelin
https://hg.mozilla.org/comm-central/rev/dd6e7061f3e6
Run black formatting on mozbuild and mozconfigure files. r=mkmelin
https://hg.mozilla.org/comm-central/rev/dfaaefc00d08
Run black formatting on MZLA files in third_party. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Reopened as suite has not landed. Review pending.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: --- → 84 Branch

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/6fe08c0e66a2
Follow-up: Reformat mozbuild files with black. rs=linting DONTBUILD

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/4fe4863303d4
Follow-up: Reformat mozbuild files with black. rs=linting

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Pushed by thunderbird@calypsoblue.org: https://hg.mozilla.org/comm-central/rev/21d8908a221d Run black formatting on suite/editor Python/mozbuild/mozconfigure files. r=IanN https://hg.mozilla.org/comm-central/rev/e9b5bfcb9795 Add Python black formatting changesets in hg annotate output. r=me DONTBUILD
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: